Closed Bug 527325 Opened 15 years ago Closed 15 years ago

SVG feConvoleMatrix doesn't process bias correctly

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta3-fixed

People

(Reporter: krit, Assigned: longsonr)

Details

Attachments

(2 files, 1 obsolete file)

feConvolveMatrix bias example
361 bytes, image/svg+xml
Details
patch
3.17 KB, patch
roc
: review+
roc
: approval1.9.2+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.1.4) Gecko/20091028 Ubuntu/9.10 (karmic) Firefox/3.5.4
Build Identifier: 

There is no bias support for feConvolveMatrix.

Reproducible: Always
example for bias. You should see a light green box.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: SVG feConvoleMatrix doesn't support bias → SVG feConvoleMatrix doesn't process bias correctly
OS: Linux → All
Hardware: x86 → All
Attached patch patch (obsolete) — — Splinter Review 
Assignee: nobody → longsonr

    
    

    
  
Comment on attachment 411098 [details] [diff] [review]
patch

wrong.

        Attachment #411098 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  
We multiply bias by 255 at the beginning of the ConvolvePixel method and again when we use it. Once is enough.

        Attachment #411287 -
        Flags: review?(roc)

    
    

    
  
pushed http://hg.mozilla.org/mozilla-central/rev/12b789f71d70
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED

    
  

        Attachment #411287 -
        Flags: approval1.9.2?

    
    

    
  
Simple low risk fix with test.

        Attachment #411287 -
        Flags: approval1.9.2? → approval1.9.2+

    
  

          status1.9.2:
          --- → final-fixed

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: