527404 - AIX Compilation error for 3.7a1pre source config/rules.mk:2079: *** missing `endif'

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Shailen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5

While compiling Mozilla Firefox source for 3.7a1pre, getting
the below error.

gmake[2]: Entering directory `/home/firefox/mozilla-central/obj-opt/xpcom/base'
/home/firefox/mozilla-central/config/rules.mk:2079: *** missing `endif'.  Stop.
gmake[2]: Leaving directory `/home/firefox/mozilla-central/obj-opt/xpcom/base'


Reproducible: Always

Steps to Reproduce:
1.Build Mozilla Firefox 3.7a1pre build on AIX with Gnome RPMS of 64 bit
version.

2.
3.
Actual Results:  
Build fails with the above error.


Expected Results:  
No build failure

Comment 1

[Jesper Hansen]

I dont see what should be wrong there.
http://hg.mozilla.org/mozilla-central/file/e980db595f62/config/rules.mk#l2079

There's only a comment on that line ±1 lines

Comment 2

[Shailen]

Attachment: Patch V 1

This patch resolves the compiler error

Comment 3

[cajbir (:cajbir)]

Comment on attachment 411133 [details] [diff] [review]
Patch V 1

Sorry, I'm the wrong person to be reviewing build/configuration files.

Comment 4

[Shailen]

Can you please review the attachment ?

Comment 5

[Shailen]

Can someone review the patch please?

Comment 6

[Brendan Eich [:brendan]]

Comment on attachment 411133 [details] [diff] [review]
Patch V 1

I'm not module owner or peer (at least, I hope I'm not!).

/be

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 411133 [details] [diff] [review]
Patch V 1

This patch is wrong. That ALL_PP_RESULTS line does not continue on to the next line. The next line simply evaluates the results of the variable assignment as makefile text. It's possible your dependency files are not being generated correctly. You can see if this is the case by running that command manually, like:
perl /home/firefox/mozilla-central/build/unix/mddepend.pl - /home/firefox/mozilla-central/obj-opt/xpcom/base/*.pp

The result should be valid makefile text. If it's not, then you should fix whatever the root cause of that is.

I'm guessing you're not using GCC, correct? Your build is probably running mkdepend to generate these. (With GCC we use -MD to make the compiler generate them.)

Comment 8

[Uli Link (:ul-mcamafia)]

(In reply to comment #7)

> I'm guessing you're not using GCC, correct? Your build is probably running
> mkdepend to generate these. (With GCC we use -MD to make the compiler generate
> them.)

Yes. IBM XLC/C++

bash-3.00$ perl /home/ulink/src/mozilla-1.9.3/build/unix/mddepend.pl - \
/home/ulink/src/mozilla-1.9.3/obj-aix/js/src/*.pp
Can't open /home/ulink/src/mozilla-1.9.3/obj-aix/js/src/*.pp: A file or directory in the path name does not exist. at /home/ulink/src/mozilla-1.9.3/build/unix/mddepend.pl line 59.
bash-3.00$

The output of toplevel configure script:
...
checking whether we are using GNU C... no
checking whether xlc_r accepts -g... yes
checking for c++... xlC_r
checking whether the C++ compiler (xlC_r  -bh:5) works... yes
checking whether the C++ compiler (xlC_r  -bh:5) is a cross-compiler... no
checking whether we are using GNU C++... no
checking whether xlC_r accepts -g... yes
checking for ranlib... ranlib
checking for as... /usr/bin/as
checking for ar... ar
checking for ld... ld
checking for strip... strip
checking for windres... no
checking whether xlc_r and cc understand -c and -o together... yes
checking how to run the C preprocessor... xlc_r -E
checking how to run the C++ preprocessor... xlC_r -E
checking for a BSD compatible install... /home/ulink/src/mozilla-1.9.3/build/autoconf/install-sh -c
checking whether ln -s works... yes
checking for minimum required perl version >= 5.006... 5.008
checking for full perl installation... yes
checking for python2.5... /opt/gnu/bin/python2.5
checking for doxygen... :
checking for whoami... /usr/bin/whoami
checking for autoconf... /opt/freeware/bin/autoconf-2.13
checking for unzip... /opt/freeware/bin/unzip
checking for zip... /opt/freeware/bin/zip
checking for makedepend... /usr/bin/X11/makedepend
...

Where to start fixing? This has worked for ages.

Comment 9

[Uli Link (:ul-mcamafia)]

https://bugzilla.mozilla.org/show_bug.cgi?id=524139

I'm using GNU make 3.80

Comment 10

[Uli Link (:ul-mcamafia)]

This effectivly prevents any kind of incremental building on AIX at this time.

Comment 11

[Uli Link (:ul-mcamafia)]

The IBM XLC/C++ equivalent to "gcc -MD foo.cpp" is 
"xlC_r -qmakedep=gcc -c foo.cpp"
The generated output will be "foo.u"

Comment 12

[Gregory Szorc [:gps]]

Closing bug against a toolchain we don't support.