[FyFx] "Sign up for news" confirmation text is in English

VERIFIED FIXED

Status

Webtools Graveyard
Five Years of Firefox
--
critical
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: Seth Bindernagel, Unassigned)

Tracking

Trunk
x86
Mac OS X

Details

(URL)

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

9 years ago
Created attachment 411262 [details]
es-ES "Thanks for signing up, We'll be in touch with more news from Mozilla soon."

At least in es-ES version, when you sign up for the news, the answer text is in
English: 

"Thanks for signing up, We'll be in touch with more news from Mozilla
soon."

Additionally, if you have already signed up and submit again, the reminder that you have already signed up is in English.  See screen shots.

It's translated on es-ES.po file
(Reporter)

Comment 1

9 years ago
Created attachment 411263 [details]
 es-ES "Thanks for signing up, We'll be in touch with more news from Mozilla soon."
(Reporter)

Updated

9 years ago
Attachment #411262 - Attachment is obsolete: true
(Reporter)

Comment 2

9 years ago
Created attachment 411264 [details]
es-ES "You are already signed up."
This is broken for all locales :( Working on it right now.
Severity: normal → critical
Found the reason.

The code responsible for registering the locale was commented out in the form processing file. That's now fixed in r55811. Furthermore, the form is submitted via javascript, and the current locale wasn't even passed to the the signup.php file. I fixed that in r55815.

This should work now on stage. Guillermo, Seth: can you please verify?
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

9 years ago
Created attachment 411474 [details]
es-ES screenshot

(In reply to comment #4)
> Found the reason.
> 
> The code responsible for registering the locale was commented out in the form
> processing file. That's now fixed in r55811. Furthermore, the form is submitted
> via javascript, and the current locale wasn't even passed to the the signup.php
> file. I fixed that in r55815.
> 
> This should work now on stage. Guillermo, Seth: can you please verify?

Verified.  Screen shots attached.
(Reporter)

Updated

9 years ago
Status: RESOLVED → VERIFIED

Updated

8 years ago
Component: Five Years of Firefox → Five Years of Firefox
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.