278 bytes, patch
|Details | Diff | Splinter Review|
In order to get the smoke tests working well on linux, it would be a great boon to have all the buffers (stdout/err) flushed when apprunner exits abnormally. currently we have automation that launches apprunner from perl and waits for an appropriate amount of time for it to load a given webpage before it kills apprunner. On linux (but not win32), the unflushed buffers just disappear, and in that lost text exists a text string "loaded successfully." could you set up a signal handler that closes the debug/status output files on sigquit (or some other appropriate signal)?
ok, i've done some research and i've determined that a nice way to do this would be to just "fflush stdout" at http://lxr.mozilla.org/seamonkey/source/xpfe/AppCores/src/nsBrowserAppCore.cpp#701 or, if that got munged, nsBrowserAppCore.cpp, line 701. that will accomplish the same thing as my first request, but will be considerably eaiser. This is one of the last blocking issues to getting apprunner smoketests for linux. thanks...
Re-assigned to firstname.lastname@example.org and set target milestone to M5.
Created attachment 47 [details] [diff] [review] this flushes stdout after a page is successfully loaded
Summary: request flushing of buffers on sigquit (at exit) → request flushing of buffers after a page loads successfully
i added one line of code to my fresh linux tree and compiled it and my smoke tests are liking it very much. this is all that needs to be done for the smoke tests on linux to run. thanks...
Status: NEW → RESOLVED
Last Resolved: 20 years ago
Resolution: --- → FIXED
Fixed. Please verify
Whiteboard: fix noted, waiting for tomorrow's morning build
i checked out nsBrowserAppCore.cpp and found the fix. i'll verify tomorrow with the qa build. (thanks for the prompt resolution of this bug...)
phillip, can you verify?
Moving all Apprunner bugs past and present to Other component temporarily whilst don and I set correct component. Apprunner component will be deleted/retired shortly.
You need to log in before you can comment on or make changes to this bug.