5276 - request flushing of buffers after a page loads successfully

Status: VERIFIED FIXED

(Core Graveyard :: Tracking, defect, P1)

Description

[phillip]

In order to get the smoke tests working well on linux,
it would be a great boon to have all the buffers (stdout/err) flushed
when apprunner exits abnormally.

currently we have automation that launches apprunner from perl and waits
for an appropriate amount of time for it to load a given webpage before
it kills apprunner. On linux (but not win32), the unflushed buffers just
disappear, and in that lost text exists a text string "loaded successfully."

could you set up a signal handler that closes the debug/status output files
on sigquit (or some other appropriate signal)?

Comment 1

[phillip]

ok, i've done some research and i've determined that a nice
way to do this would be to just "fflush stdout" at
http://lxr.mozilla.org/seamonkey/source/xpfe/AppCores/src/nsBrowserAppCore.cpp#701
or, if that got munged, nsBrowserAppCore.cpp, line 701.

that will accomplish the same thing as my first request, but will be
considerably eaiser.

This is one of the last blocking issues to getting apprunner smoketests
for linux.

thanks...

Comment 2

[don]

Re-assigned to [e-mail] and set target milestone to M5.

Comment 3

[phillip]

Attachment: this flushes stdout after a page is successfully loaded

Comment 4

[phillip]

i added one line of code to my fresh linux tree and compiled it and my smoke
tests are liking it very much. this is all that needs to be done for the
smoke tests on linux to run. thanks...

Comment 5

[Radha on family leave (not reading bugmail)]

Fixed. Please verify

Comment 6

[phillip]

i checked out nsBrowserAppCore.cpp and found the fix. i'll verify tomorrow
with the qa build. (thanks for the prompt resolution of this bug...)

Comment 7

[leger]

phillip, can you verify?

Comment 8

[phillip]

verified

Comment 9

[leger]

Moving all Apprunner bugs past and present to Other component temporarily whilst
don and I set correct component.  Apprunner component will be deleted/retired
shortly.