527641 - QuickSearch should include aliases in default search chart

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[Reed Loden [:reed]]

Attachment: patch - v1

QuickSearch supports a fastpath for aliases that will cause an immediate redirect if the query matches an alias, but aliases are not checked for any other type of request. That means a quicksearch for "CVE-2009-1563" returns bug 516396 while "ALL CVE-2009-1563" does not. Therefore, aliases should also be checked as part of the default quicksearch word search.

This patch adds an addChart() call to _default_quicksearch_word() in Bugzilla/Search/Quicksearch.pm to do a 'matches' search on the alias.

Comment 1

[Frédéric Buclin]

Comment on attachment 411373 [details] [diff] [review]
patch - v1

>+    addChart('alias', 'matches', $word, $negate);

Obviously an untested patch. You cannot use "matches" with alias.

Comment 2

[Reed Loden [:reed]]

Attachment: patch - v2

Indeed. My apologies for not checking that first by just testing query.cgi.

Comment 3

[Max Kanat-Alexander]

Sounds reasonable. Note that any QuickSearch changes are probably going to wait until bug 518293 and its blockers are checked in (because those are a major re-work of how QuickSearch works).

Comment 4

[Reed Loden [:reed]]

Attachment: patch - v3

Add documentation for the change...

Comment 5

[Max Kanat-Alexander]

Comment on attachment 425737 [details] [diff] [review]
patch - v3

>Index: Bugzilla/Search/Quicksearch.pm
>+    addChart('alias', 'equals', $word, $negate);

  That often won't have any effect, because if there's a single word and it directly matches an alias, you'll just get taken to the bug. Perhaps "substring" would be even more useful

  Otherwise this looks okay.

Comment 6

[Reed Loden [:reed]]

Attachment: patch - v4

Comment 7

[Max Kanat-Alexander]

Comment on attachment 425842 [details] [diff] [review]
patch - v4

Looks good! :-)

Comment 8

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/Search/Quicksearch.pm
modified template/en/default/pages/quicksearch.html.tmpl                       
Committed revision 6977.

Comment 9

[Reed Loden [:reed]]

Considering the huge overhaul of quicksearch in 3.6, it would be nice to get this two-line patch into 3.6 with the other changes.

Comment 10

[Max Kanat-Alexander]

Sounds reasonable.

Comment 11

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/
modified template/en/default/pages/quicksearch.html.tmpl
modified Bugzilla/Search/Quicksearch.pm
Committed revision 7062.