527673 - Assertion Failed when bookmarking page from menu or using Ctrl+D shortcut

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[fardan89]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1) Gecko/20091029 Firefox/3.6b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b1) Gecko/20091029 Firefox/3.6b1

The following error results when you try to bookmark the page using the menu or the Ctrl+D shortcut


Assertion Failed

ASSERT: parent node must have _DOMElement set
Stack Trace: 
0:PMV_nodeRemoved([object ResultNodeClassInfo],[object ResultNodeClassInfo],10)
1:removeItem(152)
2:PCIT_undoTransaction()
3:undoTransaction()
4:placesTxn_undoTransaction()
5:undoTransaction()
6:SU_cancelButtonOnCommand()
7:oncommand([object XULCommandEvent])


Reproducible: Always

Steps to Reproduce:
1.Press Ctrl+D OR click on "Bookmark This Page" under bookmarks menu
Actual Results:  
The following error results when you try to bookmark the page using the menu or the Ctrl+D shortcut


Assertion Failed

ASSERT: parent node must have _DOMElement set
Stack Trace: 
0:PMV_nodeRemoved([object ResultNodeClassInfo],[object ResultNodeClassInfo],10)
1:removeItem(152)
2:PCIT_undoTransaction()
3:undoTransaction()
4:placesTxn_undoTransaction()
5:undoTransaction()
6:SU_cancelButtonOnCommand()
7:oncommand([object XULCommandEvent])

Expected Results:  
The Assertion Failed Error should not be happen.

FIREFOX ADD-ONS INSTALLED:
Adblock Plus
Chromifox Companion
Download StatusBar
Gmail Notifier
Java Quick Starter
Pray Times
Tab Mix Plus
WorldIP

FIREFOX THEME USED:
Chromifox Extreme


ABOUT;BUILDCONFIG

Source

Built from http://hg.mozilla.org/releases/mozilla-1.9.2/rev/3b49c063bb42
Build platform
target
i686-pc-mingw32

Build tools
Compiler 	Version 	Compiler flags
cl 	14.00.50727.762 	-TC -nologo -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1
cl 	14.00.50727.762 	-GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1

Configure arguments
--enable-application=browser --enable-update-channel=beta --enable-update-packaging --enable-jemalloc --enable-official-branding

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Can you please run Firefox in Safe Mode (http://support.mozilla.com/kb/Safe+Mode) to check if an extension is causing this problem? Is it reproducible all the time? Could happen due to a broken places.sqlite file. We can continue once you are able to give feedback. Thanks.

Comment 2

[fardan89]

I am not able to reproduce the error anymore, I tried in safe mode also.
Although my addons have changed, they are now the following:

Adblock Plus
Java Quick Starter
Pray Times
Tab Mix Plus

and theme is default

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Fardan. If you are able to reproduce at some time feel free to reopen the bug. Until then lets close it as incomplete.

Comment 4

[Carsten Book [:Tomcat]]

reopen - we have dupes comming in, maybe this was closed too fast as incomplete

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #4)
> reopen - we have dupes comming in, maybe this was closed too fast as incomplete

That was wrongly duped. Perhaps this bug will also be a dupe of bug 525480. I will check it.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Once you are in a state by following the steps on bug 525480 you will hit this assertion when trying to remove an already bookmarked page. The stack is a bit different. Marco, do we wanna catch all in bug 525480?

Comment 8

[Marco Bonardo [:mak]]

if STRs are different, i prefer separate bugs, we can't state if it' the same bug or not atm. it could end being the same thing, but we can't tell offhand.
We fire this assertion in many different places, so...

Comment 9

[Marco Bonardo [:mak]]

clearly we can't debug any bug without STRs, so those can be duped.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Fardan, can you please check the steps on bug 525480? Have you done any toolbar customization before you have seen this assertion? If yes, can you reproduce it with those steps?

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #10)
> Fardan, can you please check the steps on bug 525480? Have you done any toolbar
> customization before you have seen this assertion? If yes, can you reproduce it
> with those steps?

Fardan, can you please give feedback to my question above?

Comment 12

[fardan89]

I removed the add-ons and reset the toolbar, and the problem I was unable to reproduce the problem.
I had just added the new tab button to my toolbar earlier.
Sorry for the late reply, I had read the e-mail in a a hurry and forgot to mark it back as unread so I didn't notice it the next time I checked my inbox.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #9)
> clearly we can't debug any bug without STRs, so those can be duped.

Lets add dependency for now. We should reconsider later.

Comment 14

[Drew Ruderman]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a5pre) Gecko/20100411 Minefield/3.7a5pre (.NET CLR 3.5.30729)

I got this error recently while trying to bookmark a page.  It seems to occur sporadically.

The addons I am using are:

1. Add-on Compatibility Reporter 0.4.2
2. Adblock Plus 1.1.3+.2010040102
3. BugMeNot 2.2
4. Greasemonkey - 0.8.20100211.5
5. Microsoft .NET Framework Assistant - 1.1
6. Move Media Player - 7
7. RealPlayer Browser Record Plugin - 1.0
8. Stumble Upon - 3.62
9. Firebug - 1.5.3 (disabled)

The first time, the stack traces was: 

ASSERT: parent node must have _DOMElement set
Stack Trace: 
0:PMV_nodeInserted([object ResultNodeClassInfo],[object ResultNodeClassInfo],93)
1:insertBookmark(2,[xpconnect wrapped nsIURI],-1,¤)
2:PCIT_doTransaction()
3:doTransaction([xpconnect wrapped nsITransaction])
4:placesTxn_doTransaction([xpconnect wrapped nsITransaction])
5:doTransaction([xpconnect wrapped nsITransaction])
6:PCH_bookmarkPage([object XULElement],2,true)
7:PCH_bookmarkCurrentPage(true,2)
8:oncommand([object XULCommandEvent])

The second time, the stack trace was:

ASSERT: parent node must have _DOMElement set
Stack Trace: 
0:PMV_nodeInserted([object ResultNodeClassInfo],[object ResultNodeClassInfo],93)
1:insertBookmark(2,[xpconnect wrapped nsIURI],-1,¤)
2:PCIT_doTransaction()
3:doTransaction([xpconnect wrapped nsITransaction])
4:placesTxn_doTransaction([xpconnect wrapped nsITransaction])
5:doTransaction([xpconnect wrapped nsITransaction])
6:PCH_bookmarkPage([object XULElement],2,true)
7:PCH_bookmarkCurrentPage(true,2)
8:oncommand([object XULCommandEvent])

Comment 15

[Asaf Romano (gone)]

Closing as WFM for now.  See bug 528006.