527713 - toggleFIPS in device_manager.js should not use window.alert

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Marek Stępień [:marcoos, inactive]]

Attachment: Screenshot (from http://bugs.aviary.pl/show_bug.cgi?id=2753)

toggleFIPS() uses the generic JS window.alert method to display an alert window.
This is bad, as this alert window looks like an alert from a webside, with "[JavaScript Application]" in its title, while it's an application-level alert.

Probably nsIPromptService's alert method would be a better choice here. :)

(This bug was originally filed in the Polish localization team's Bugzilla - http://bugs.aviary.pl/show_bug.cgi?id=2753 )

Comment 1

[Marek Stępień [:marcoos, inactive]]

To reproduce:

1. In Firefox, go to Preferences -> Advanced -> Encryption -> Security Devices -> Enable FIPS

Comment 2

[Marek Stępień [:marcoos, inactive]]

Attachment: Patch

There's already a doPrompt function which does wrap around nsIPromptService's alert method and is used throughout this script.

This patch replaces the two occurences of JS alert() function calls with doPrompt() wrapper calls.

(Though probably its name should really be doAlert instead of doPrompt)

Comment 3

[Kai Engert (:KaiE:)]

Comment on attachment 411587 [details] [diff] [review]
Patch

r=kaie

thanks for this patch, I've tested it.

I see there are additional occurrences in security/manager/pki where a simple alert is being used, which give the same effect.

Comment 4

[Marek Stępień [:marcoos, inactive]]

Attachment: Replace other alerts, too :)

This replaces all alerts with promptService.alert (even the commented-out ones). 
(Basically, copied the doPrompt function from device_manager.js to other scripts and replaced all alerts with it).

Comment 5

[Bob Lord]

Did this patch get checked in?

Comment 6

[Kai Engert (:KaiE:)]

Comment on attachment 412032 [details] [diff] [review]
Replace other alerts, too :)

r=kaie

I wish we could move the doPrompt function to a single place, and include from everywhere.

But given the function is really small and trivial, I won't bother, unless you're up to doing it.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/226f250e9e9c