'No results' item should clear the previous result data

VERIFIED FIXED in fennec1.0

Status

Fennec Graveyard
General
VERIFIED FIXED
8 years ago
4 years ago

People

(Reporter: mfinkle, Assigned: Gijs)

Tracking

Trunk
fennec1.0
x86
Linux

Details

Attachments

(1 attachment, 1 obsolete attachment)

The 'No results' part of the awesomebar is just a reused awesomebar entry. It could have data assigned to it from previous results.

Those parts need to be cleared.

See a left over 'tag':
http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-noresults-bug.png
(Reporter)

Updated

8 years ago
tracking-fennec: --- → ?
(Assignee)

Comment 1

8 years ago
Created attachment 411465 [details] [diff] [review]
Patch clearing out the element in updateNoResultsItem

Per discussion on IRC.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #411465 - Flags: review?(gavin.sharp)
Comment on attachment 411465 [details] [diff] [review]
Patch clearing out the element in updateNoResultsItem

Let's also remove the hunk at http://mxr.mozilla.org/mobile-browser/source/themes/hildon/browser.css#625 , in both themes.
Attachment #411465 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 3

8 years ago
Created attachment 411468 [details] [diff] [review]
Patch

Tested patch with those hunks removed. Carrying over review.
Attachment #411465 - Attachment is obsolete: true
Attachment #411468 - Flags: review+
(Assignee)

Comment 4

8 years ago
http://hg.mozilla.org/mobile-browser/rev/e86d8b93608b
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
verified FIXED (searching for strings that will populate tags and bookmarks items [then extraneous strings added on to that string]) on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b3pre) Gecko/20091111 Firefox/3.6b2pre Fennec/1.0b5

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091111 Firefox/3.7a1pre Fennec/1.0b5
Status: RESOLVED → VERIFIED
Target Milestone: --- → Post-B5
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.