527716 - 'No results' item should clear the previous result data

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

The 'No results' part of the awesomebar is just a reused awesomebar entry. It could have data assigned to it from previous results.

Those parts need to be cleared.

See a left over 'tag':
http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-noresults-bug.png

Comment 1

[:Gijs (he/him)]

Attachment: Patch clearing out the element in updateNoResultsItem

Per discussion on IRC.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 411465 [details] [diff] [review]
Patch clearing out the element in updateNoResultsItem

Let's also remove the hunk at http://mxr.mozilla.org/mobile-browser/source/themes/hildon/browser.css#625 , in both themes.

Comment 3

[:Gijs (he/him)]

Attachment: Patch

Tested patch with those hunks removed. Carrying over review.

Comment 4

[:Gijs (he/him)]

http://hg.mozilla.org/mobile-browser/rev/e86d8b93608b

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED (searching for strings that will populate tags and bookmarks items [then extraneous strings added on to that string]) on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b3pre) Gecko/20091111 Firefox/3.6b2pre Fennec/1.0b5

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091111 Firefox/3.7a1pre Fennec/1.0b5