527739 - Make availability of delete button consistent across all Address book

Status: RESOLVED WONTFIX

(Thunderbird :: Address Book, defect)

Description

[Nir]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4) Gecko/20091027 Fedora/3.5.4-1.fc11 Firefox/3.5.4 XPCOMViewer/0.9a
Build Identifier: 

When you open Address book either from Toolbar in main window or from Tools > Address Book 'Delete' button is available/enabled for Personal address book with very first address book contact entry selected in right pane. If you click on Delete icon that entry will be deleted.

Although if you select any other address book or list 'Delete' button will not remain enabled/available unless you select a contact entry manually.

Reproducible: Always

Comment 1

[Nir]

Btw, I'm using 
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.6pre) Gecko/20091110 Shredder/3.0pre

Comment 2

[Mark Banner (:standard8)]

So if we do what you suggest, then you won't be able to delete an address book or mailing list via the toolbar button?

The behaviour here is exactly the same as for the folders/message panes.

Comment 3

[Nir]

(In reply to comment #2)
> So if we do what you suggest, then you won't be able to delete an address book
> or mailing list via the toolbar button?

It's not about Address Book or Mailing list. It's about contact entry.
When the first time Address Book is opened from toolbar of main UI, following thing you will notice:
1. Personal Address Book is highlighted in left pane.
2. First contact in Personal Address book is highlighted in right pane.
3. Delete button is active in Toolbar.

At this point if you click on delete, that highlighted contact will be removed.
But at this point if you select any other AB, delete button will no longer be active unless you select a contact in that AB. If you click on Delete button after that, that selected contact will be removed.

What I'm suggesting is either

On start, don't auto-select the first entry in PAB and make delete button unavailable. 

or On selection of other AB, auto-select the first contact and make Delete button available.
> The behaviour here is exactly the same as for the folders/message panes.

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

I see, this is the behavior I'm seeing.  When you select an address book we select an entry but do not focus it.  Therefore the delete button is inactive.  This behavior is different than the first load because we always focus the first entry of the first book at that time.

I could see making the first click on an Address Book focus the first entry.  Future clicks would likely have to ignore that focus shift so we don't make it impossible to focus the address book.  I'm not sure what the a11y team would think of a focus trick like that though.

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> I could see making the first click on an Address Book focus the first entry. 
> Future clicks would likely have to ignore that focus shift so we don't make it
> impossible to focus the address book.  I'm not sure what the a11y team would
> think of a focus trick like that though.

I think that would just be a nightmare for normal users, let alone the a11y team.

FWIW this is still exactly how the main message window with folder pane + message list works.

I really think the real issue here is that we have no undo which is covered by an already existing bug.

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #5)
> I really think the real issue here is that we have no undo which is covered by
> an already existing bug.

Agreed.  I'm going to mark this won't fix then.  I can't seem to find the AB undo support bug