527772 - New [@nsTArray<nsGeolocation*>::AppendElements<nsGeolocation*>(nsGeolocation* const*, unsigned int)] crash in 3.5.5

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Johnny Stenback (:jst)]

There's a new crash with the signature nsTArray<nsGeolocation*>::AppendElements<nsGeolocation*>(nsGeolocation* const*, unsigned int) in 3.5.5 that hasn't shown up in any earlier releases. So far there are no reports of this on the trunk, but we don't have nearly as many users so it might just not have been hit yet.

Comment 1

[Doug Turner (:dougt)]

http://crash-stats.mozilla.com/report/index/96cad4b4-64bb-423f-b3c5-2427f2091110
http://crash-stats.mozilla.com/report/index/33af2a13-7fab-4888-b49f-1ee692091108

Comment 2

[Samuel Sidler (old account; do not CC)]

Weird that it'd show up in 3.5.5 and not 3.5.4. We didn't take any geolocation changes in 3.5.5.

Comment 3

[timeless]

Signature	nsTArray<nsGeolocation*>::AppendElements<nsGeolocation*>(nsGeolocation* const*, unsigned int)
UUID	33af2a13-7fab-4888-b49f-1ee692091108
Time 	2009-11-08 07:36:53.327011
Uptime	100
Last Crash	93331 seconds before submission
Product	Firefox
Version	3.5.5
Build ID	20091102152451
Branch	1.9.1
OS	Windows NT
OS Version	5.1.2600 Service Pack 3
CPU	x86
CPU Info	GenuineIntel family 15 model 4 stepping 9
Crash Reason	EXCEPTION_ACCESS_VIOLATION
Crash Address	0x0
User Comments	je to čím dál horší
Processor Notes 	
Related Bugs

Crashing Thread
Frame 	Module 	Signature [Expand] 	Source
0 	xul.dll 	nsTArray<nsGeolocation*>::AppendElements<nsGeolocation*> 	obj-firefox/dist/include/xpcom/nsTArray.h:551
1 	xul.dll 	nsGeolocation::nsGeolocation 	dom/src/geolocation/nsGeolocation.cpp:596
2 	xul.dll 	nsNavigator::GetGeolocation 	dom/src/base/nsGlobalWindow.cpp:9661
3 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
4 	xul.dll 	XPCWrappedNative::CallMethod 	js/src/xpconnect/src/xpcwrappednative.cpp:2456

so, that's a null pointer crash at 0x0.

the other one is a bit odd 0x404

Signature	nsRefPtr<nsFormControlList>::assign_with_AddRef(nsFormControlList*)
UUID	96cad4b4-64bb-423f-b3c5-2427f2091110
Time 	2009-11-10 12:58:38.850580
Uptime	16305
Last Crash	275918 seconds before submission
Product	Firefox
Version	3.5.5
Build ID	20091102152451
Branch	1.9.1
OS	Windows NT
OS Version	6.0.6002 Service Pack 2
CPU	x86
CPU Info	GenuineIntel family 6 model 15 stepping 13
Crash Reason	EXCEPTION_ACCESS_VIOLATION
Crash Address	0x404
User Comments	
Processor Notes 	
Crashing Thread
Frame 	Module 	Signature [Expand] 	Source
0 	xul.dll 	nsRefPtr<nsFormControlList>::assign_with_AddRef 	obj-firefox/dist/include/xpcom/nsAutoPtr.h:927
1 	xul.dll 	nsGeolocation::nsGeolocation 	dom/src/geolocation/nsGeolocation.cpp:594
2 	xul.dll 	nsNavigator::GetGeolocation 	dom/src/base/nsGlobalWindow.cpp:9661
3 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
4 	xul.dll 	XPCWrappedNative::CallMethod 	js/src/xpconnect/src/xpcwrappednative.cpp:2456

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Doug thinks bug 493615 may help with this - Doug, do you think this should block?

Comment 5

[Doug Turner (:dougt)]

we can fix this independent of all of the stuff in 493615.  in that bug, we make it impossible to pass a null to the nsGeolocation constructor from the global window.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

OK, would take a patch, don't think it blocks, should definitely get it on a support release if not by final.

Comment 7

[Doug Turner (:dougt)]

I no longer see this on crash stats.