527800 - NPCocoaEvent structures sometimes not initialized in nsChildView.mm

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Steven Michaud [:smichaud] (Retired)]

Support was recently added on the trunk for the Cocoa event model in
plugins.  But this support still has problems -- among them the
following:

There are several places in nsChildView.mm where an NPCocoaEvent
structure is created (and sent to a plugin) without being properly
initialized.  This can lead to crashes, both in my DebugPluginEvents
plugin from bug 441880 and in Apple's NetscapeCocoaPlugin example from
WebKit code.

What specifically causes the crashes is that, in the case of an
NPCocoaEventFlagsChanged event, the data.key.characters and
data.key.charactersIgnoringModifiers fields are unitialized.  Each of
these is a pointer to an NPNSString (the equivalent of a pointer to an
NSString).

A patch will follow shortly.

Comment 1

[Steven Michaud [:smichaud] (Retired)]

Attachment: Fix

Comment 2

[Josh Aas]

We should just call "InitNPCocoaEvent" at the top of "ConvertCocoaKeyEventToNPCocoaEvent".

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Attachment: Fix rev1 (follow Josh's suggestion)

That also works.

Comment 4

[Steven Michaud [:smichaud] (Retired)]

Landed on trunk:
http://hg.mozilla.org/mozilla-central/rev/e3077f83f366