527822 - Throbber shown for media elements without any sources to load.

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.1 (WIP)

Ehsan noticed that "<video controls></video>" results in a throbber being displayed.

This doesn't seem good to me, the throbber is implying something is going on, when there's really no activity. I think we should just show the error icon for this condition. [If pages want to have empty media elements that have sources loaded by external triggers, they should disable the default controls when there's nothing available.]

The patch here does that. The error icon will come up after a short delay, so that if there's script on the page that immediately triggers the load algorithm, we'll switch back to the throbber when loadstart fires (which should basically happen right away).

Comment 1

[(no longer active)]

Comment on attachment 411566 [details] [diff] [review]
Patch v.1 (WIP)

>diff --git a/toolkit/content/widgets/videocontrols.xml b/toolkit/content/widgets/videocontrols.xml
>-                debug : false,
>+                debug : true,

Is this change intentional?

Also, have you tried this patch with the audio/video control tests?  I'm asking because those tests might be sensitive to this change...

Oh, and I guess we can get some automated (ref)tests here as well just to make sure that this doesn't regress in the future.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

This has been fixed by bug 505158.