Closed Bug 527874 Opened 15 years ago Closed 15 years ago

nanojit: add and remove some uses of findSpecificRegForUnallocated()

Categories

(Core :: JavaScript Engine, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey)

Attachments

(1 file)

Attached patch patchSplinter Review
rreitmai reported some Tamarin assertions within findSpecificRegForUnallocated().  The changes in this patch to Nativei386.cpp should get rid of them.  rreitmai, can you please test the patch?  Thanks.

I also took the opportunity to apply some uses of findSpecificRegForUnallocated() in the X64 backend.
Attachment #411625 - Flags: review?(rreitmai)
Summary: nanojit: add and removed some uses of findSpecificRegForUnallocated() → nanojit: add and remove some uses of findSpecificRegForUnallocated()
Comment on attachment 411625 [details] [diff] [review]
patch

yes, this patch fixes the issue.
Attachment #411625 - Flags: review?(rreitmai) → review+
http://hg.mozilla.org/tracemonkey/rev/515d7e584de6
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tracemonkey
Blocks: 528305
Any ETA on this making m-c?
Hi Nicholas.  This still hasn't made it to mozilla-central, but I applied the patch from tracemonkey manually to Nativei386.cpp and it works for me :o)
Walter, good.  I expect it'll go into m-c the next time Sayre does one of his periodic merges.
Blocks: 529381
http://hg.mozilla.org/mozilla-central/rev/515d7e584de6
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: