Closed
Bug 527930
Opened 15 years ago
Closed 15 years ago
Implement the GS spec
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect, P1)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
VERIFIED
FIXED
5.4
People
(Reporter: clouserw, Assigned: clouserw)
References
()
Details
Attachments
(7 files)
I've got a JS file to host locally, other than that we just need to store the company name and potentially product name.
Updated•15 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•15 years ago
|
||
I'm boarding the plane in 6 minutes so here are some screenshots for feedback. First: Looking for feedback on wording. I think we could fix bug 499482 at the same time, so assume we remove the "support" section in the middle of the page if we have this box in the top right. I can make the box as wide as the others if you want - using the prose class squished it down.
Attachment #412425 -
Flags: review?(nnguyen)
Attachment #412425 -
Flags: review?(fligtar)
Assignee | ||
Comment 2•15 years ago
|
||
This is editing the properties of an add-on. These are the only two fields we need. Basically looking for feedback on wording again. This will show up for all locales but the screenshot above (on the page) will only show up if the user is using en-US.
Attachment #412426 -
Flags: review?(nnguyen)
Attachment #412426 -
Flags: review?(fligtar)
Assignee | ||
Comment 3•15 years ago
|
||
Here is a screenshot of the actual GS widget once activated on the page. This is all defaults. There isn't good documentation available for this widget but we can do whatever we want via CSS. There is a close button on the top left, but it didn't load because the wireless here sucks.
Attachment #412427 -
Flags: review?(nnguyen)
Attachment #412427 -
Flags: review?(fligtar)
Comment 4•15 years ago
|
||
Is there any way to embed a widget inline? I'm worried the single link might not be discoverable.
Assignee | ||
Comment 5•15 years ago
|
||
(In reply to comment #4) > Is there any way to embed a widget inline? I'm worried the single link might > not be discoverable. It didn't fit in that column very well when I tried it.
Comment 6•15 years ago
|
||
Box: Yeah, this should definitely be the same width as the others. Perhaps for copy, make it more obvious that this is help for the specific add-on rather than help with add-ons or Firefox in general. Let's also promote Get Satisfaction first if it's available for the add-on. Need help with this add-on? * Ask others on _Get_Satisfaction_ * Visit the _support_website_ * _E-mail_ your question On the Dev tools: I think this is good. Perhaps the Product explanation could use an example like in the first one to help people figure out what to put in the box. Widget overlay: This looks good
Assignee | ||
Comment 7•15 years ago
|
||
Thanks fligtar. I tweaked the wording a bit
Attachment #412937 -
Flags: review?(fwenzel)
Comment 8•15 years ago
|
||
I'm not sure if having the support stuff in the sidebar is the best placement - it will probably get lost there and not noticed. If we're locked on having the support box in the sidebar, I'd move it up to be the very first box. Getting support is more important to most users than information about the developer or related add-ons. I think the best location is to have a call-out box that appears above the details table - again, knowing how to find support is probably a bigger priority for an add-on's users than that add-on's minutiae. If this is something we'd like to pursue I can do a mockup - let me know.
Assignee | ||
Comment 9•15 years ago
|
||
Moving it to the sidebar is (In reply to comment #8) > I'm not sure if having the support stuff in the sidebar is the best placement - > it will probably get lost there and not noticed. > > If we're locked on having the support box in the sidebar, I'd move it up to be > the very first box. Getting support is more important to most users than > information about the developer or related add-ons. > > I think the best location is to have a call-out box that appears above the > details table - again, knowing how to find support is probably a bigger > priority for an add-on's users than that add-on's minutiae. > > If this is something we'd like to pursue I can do a mockup - let me know. I think moving it to the sidebar is a lot better than where it is now, and I'd rather have it on the side than in the middle. That area is already crowded. If we want to emphasize it there are other ways like tweaking the background color or giving it a border or fancy-ish background image but let's try this and see how it goes.
Comment 10•15 years ago
|
||
Comment on attachment 412937 [details] [diff] [review] patch It works well, almost completely, but when I click on the link in the sidebar, the dark overlay over the page only spans the content part of the page, not the entire thing (hard to explain, I'll add a screenshot). That could be an un-closed <div> somewhere or something. If you fix this, it's an r+.
Attachment #412937 -
Flags: review?(fwenzel) → review-
Comment 11•15 years ago
|
||
That's what I was referring to: the dark gray does not span all the way across the page.
Assignee | ||
Comment 12•15 years ago
|
||
Attachment #413355 -
Flags: review?(fwenzel)
Comment 13•15 years ago
|
||
Comment on attachment 413355 [details] [diff] [review] incremental fix Faaaantastic.
Attachment #413355 -
Flags: review?(fwenzel) → review+
Updated•15 years ago
|
Attachment #412937 -
Flags: review- → review+
Assignee | ||
Comment 14•15 years ago
|
||
r56437
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•15 years ago
|
Attachment #412425 -
Flags: review?(nnguyen)
Attachment #412425 -
Flags: review?(fligtar)
Assignee | ||
Updated•15 years ago
|
Attachment #412426 -
Flags: review?(nnguyen)
Attachment #412426 -
Flags: review?(fligtar)
Assignee | ||
Updated•15 years ago
|
Attachment #412427 -
Flags: review?(nnguyen)
Attachment #412427 -
Flags: review?(fligtar)
Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/addon/9331.
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•