527945 - weave doesn't use custom server url when using "Start Over"

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Sebastian Wiesinger]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: 1.0b1pre1

I'm running my own weaver server and tried to enter new account details via the "Start Over" function.

I entered my server url and tried to log in but always got an username/password error. Checking about:config I saw that Weave used the default mozilla server instead of my own.

Even worse this is sort of a dead lock. Firefox will not save your weave username/password if the login doesn't work and you can't change the about:config setting while the weave preferences dialog is open. If your close the preferences window and change the settings with about:config and then open the preferences window again the server settings are changed back to the Mozilla servers whenn selecting "Start Over"

My only workaround to get this working is to open a second Firefox window while the Weave preferences are open on the "Start Over" page and change the values in about:config by hand.

Reproducible: Always

Steps to Reproduce:
1. Use "Start Over" or a new setup and select "Use a custom Server"
2. Enter an URL in the "Server URL" field
3. Look in about:config and see that Weave is still using the Mozilla server

Actual Results:  
Weave tries to authenticate with the Mozilla Weave server.

Expected Results:  
Weave authenticates with my custom server.

Comment 1

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/518a926427da
bug 527945 - fix bad if check, because I suck, and make the parsing real