Closed Bug 52798 Opened 24 years ago Closed 23 years ago

gif img in table with width=100% blinks rapidly (flashes, flickers) (can happen without tables) [layout]

Categories

(Core Graveyard :: GFX, defect, P3)

Product:
Core Graveyard
Component:
GFX
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9

People

(Reporter: ewv, Assigned: dcone)

References

(
URL
)

Details

(4 keywords, Whiteboard: This is fixed by the new imagelib)

Attachments

(5 files)

test case (may have to reload to see problem)
330 bytes, text/html
Details
A sampling of the problem. Missing image in TD.
2.90 KB, text/html
Details
zipped testcase (html + gif)
446 bytes, application/x-zip-compressed
Details
URL of further test case: does not depend on width=100%
143 bytes, text/plain
Details
url for _really_ blinking image (other images don't blink for me)
138 bytes, text/plain
Details 
On a fresh start, with this as my home page, the "rainbow lines" blink
erratically (but all at the same time). Going to another page and then "back"
solves the problem.

Build: 2000091506. Did not occur with 2000090808.
I'm seeing this on Linux 2000-09-15-06.  See also http://news.gnome.org at the
bottom of the page.  The horizontal line (which is actually a scaled GIF) blinks
continuously.  In debug builds, this asserts continuously but my debug build is
horked right now so I can't remember the assertion.
URL: www-focus.fnal.gov → http://www-focus.fnal.gov
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 53022 has been marked as a duplicate of this bug. ***
If the above URL is in your cache, it won't blink.    Hit reload to see the show.
OS: Linux → All
Summary: Blink GIF images → Scaled GIF images blink during and after page load
I am seeing the problem at http://news.gnome.org, but not at
http://www-focus.fnal.gov (I think the page has changed and there aren't any
animated gif's on it anymore.)

Reassigning to dcone.
Assignee: kmcclusk → dcone
Correct in that http://www-focus.fnal.gov/ isn't blinking anymore (I'm now using
build 2000092008), but the page has not changed. There never were animated gifs
on the site. The problem was alleged to be with scaled gifs. These gifs are
still scaled.

I too am still seeing the problem at http://news.gnome.org
Status: NEW → ASSIGNED
Target Milestone: --- → Future
Nothing will happen the first time you load the testcase or the Gnotices page.  
If you hit reload, the image will flash a few times and then collapse (on the 
original gnome page) or expand (on the testcase).  I think what's happening in 
each case is that it's getting replaced by alt text, which melts into the other 
stuff on the "gnotices" page but causes the table to expand in the testcase.  
After playing with the page for a while, Mozilla may just let it keep flashing 
forever (this happened twice while I was simplifying), but restarting Mozilla 
will return the page to its "normal" behavior of making it flash a few times 
and then implode.

Note that the testcase requires having a background image.  I think the 
background image and the width=100% image might be fighting over who gets to 
display.  Bug 49222 *might* explain why pressing escape makes it stop flashing 
when you press escape.
Hardware: PC → All
Summary: Scaled GIF images blink during and after page load → gif img in table with width=100% blinks rapidly (flashes)
Ok, I see this on another site (www.avis.com). The top td of table conatins a 
image assigned a width="100%". This image will flash when reload or disappear 
completely. Changing width to pixels will solve the problem.

*** Bug 57122 has been marked as a duplicate of this bug. ***
I will attach another testcase. Unzip the file (HTML + GIF) to your local hard
disk, load the HTML file and reload it. The image in the tabel will flash rapidly.

The source code (body):

<BODY>
  <TABLE border=1>
    <TR>
      <TD>
        thisisaratherlongword
      </TD>
    </TR>
    <TR>
      <TD>
        <IMG src="vrr_strich.gif" width="100%" height="3">
      </TD>
    </TR>
  </TABLE>

*** Bug 56015 has been marked as a duplicate of this bug. ***
*** Bug 57271 has been marked as a duplicate of this bug. ***
I see this at the original url today (http://www-focus.fnal.gov/).
Summary: gif img in table with width=100% blinks rapidly (flashes) → gif img in table with width=100% blinks rapidly (flashes, flickers)
Adding "Mostfreq" keyword and "crash" keyword because many users of mozilla have
complained to me about it, and the browser ends up freezing on these pages with
flickering lines if I don't stop the line from flickering in time.
Keywords: crash, mostfreq
Adding mlk (memory leak) keyword based on dup bug 56015.
Keywords: mlk
*** Bug 58330 has been marked as a duplicate of this bug. ***
*** Bug 58645 has been marked as a duplicate of this bug. ***
This happens even in a window with no status bar, so the problem isn't an 
interaction between the progress bar and the page.  For example, load 

javascript:void(window.open("http://slashdot.org/comments.pl?
sid=00/10/30/2259230&cid=21&light=0","","resizable=yes,scrollbars=yes"))

(scroll down to bottom, hit Ctlr-R)
Is it certain that width=100% is an ingredience of this bug?
http://www.nor.no
There's a horisontal gif scaled to 98% there.
On occation it behaves eratically and vanishes on reload.
If i go there with PSM installed, and click the button to enter the bank
services at the site, behaviour can get real weird.
The gif goes into some reload loop, and for each loop a new PSM thread seems to
be spawned. Don't know who's the chicken or egg in that bug, but it kept
flickering and i had 60 PSM processes hanging in no time.
Again: I just want a confirmation that the assumption about 100% width is
correct here, in which case i'm observing another bug.

rkaa: I'm pretty sure it's the same bug, because you have to reload to trigger 
it, and it flickers in the same way.  I'd leave the width=100% in the summary, 
though, because it's a useful way to keep track of infinite reflow bugs and 
other bugs that happen when large % widths confuse layout.

Can you file another bug on the extra psm processes?  That sounds like a 
serious memory leak, and it seems likely that it could be triggered by other 
infinite reflow bugs (or maybe even dom actions).
Already filed an exquisite PSM horror-bug (56366). Just trying to figure out
what else haunts it, since some of the bad behaviour obviously origin in mozilla
bits, not psm. I guess someone (if they tried) could split out a handful
assorted bugs from 56366. Glad to see this is one of them :)
Adding to mozilla 0.9 radar. It doesn't appear in as many places as it used to,
but when it does, it will ALWAYS cause a crash over time.
Keywords: mozilla0.9
This bug is probably causing the problems at amihotornot.com (bug 58963).
Set milestone to mozilla0.9
Target Milestone: Future → mozilla0.9
Adding self to cc, causing trouble for my sites too.

reproduced images flashing with gif, jpeg, png; without background images or 
percentual sizes. Flashing occurs when images are resized by javascript to 
widths or heights with decimals, i.e. trying to set a height of 100.8 pixels. 
Guess the same could be happening in reflows with percentages, the numbers don't 
get rounded and something gets confused? Setting decimal sizes in img tag 
doesn't cause blinky behavior. Tested 0.6 and win32-talkback of 2001y01m04d.
http://www.pp.htv.fi/etolvane/tt/randomdata/index_blinkytest-v6.html
Not sure if someone's already mentioned this, but the images are being reloaded
here - at the very least that PNG is being decompressed by libpng over and over.
You can see that because the PNG is slightly b0rked (Photoshop bug) and libpng
complains to console "Incomplete compressed datastream in iCCP chunk".
Presumably the GIF and JPEG are being reloaded too. I can't tell if they're
fetched from the network or just from cache.
I hope this information makes it easier to figure out what's actually wrong.
Yes, I noticed on the original page (www-focus.fnal.gov) that it was reloading
from the network because it was generating lots of network traffic.

I don't know if this was the case earlier.
*** Bug 65032 has been marked as a duplicate of this bug. ***
*** Bug 67733 has been marked as a duplicate of this bug. ***
*** Bug 60874 has been marked as a duplicate of this bug. ***
Very annoying.
Also check out the bug 56548. I think they are dups.
Blocks: 61477
Another URL where it occurs consistantly:
http://bbspot.com/toys/slashtitle/index.html

*** Bug 69233 has been marked as a duplicate of this bug. ***
I belief that bug 65614 is a dup of this one. I found that if you set <table
width="95%"> (or any other value) then the flashing and reloads for those images
will stop. Also note that mozilla keep recalculating the image size if % width
is used. There are at least two functions in the source doing this kind of
calculation for HTMLElements one of those two must be the cause for this pain.
*** Bug 65614 has been marked as a duplicate of this bug. ***
I understand that bug 65614 was more recent, so it got marked as a duplicate. 
However, I think the summary on that bug is more accurate; can we replace this
summary with that one?

Also, note that this seems to be a reflow loop -- something involved in scaling
images by percentage (not by pixels) triggers a reflow, which re-scales the
images, which triggers a reflow, which re-scales the images, which triggers a
reflow...

As I commented in bug 65614, the following webpage demonstrates this clearly;
scroll halfway down the page and watch the multiple scaled-by-percentage images
flicker and shrink repeatedly:

http://www.nichia.co.jp/lamp-e.htm

Interestingly, it DOES eventually stop reflowing, after dozens (hundreds?) of
reflows...  (I don't know if this has any significance.)
Cool, one of the testcases on bug 65614 doesn't use tables:
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=22669
Summary: gif img in table with width=100% blinks rapidly (flashes, flickers) → gif img in table with width=100% blinks rapidly (flashes, flickers) (can happen without tables)
*** Bug 56548 has been marked as a duplicate of this bug. ***
I wonder if this is caused by bug 69534?  I hope so, because I have a fix for
it. Basically, GIFs are causing reflows for every pane of the animation (for
some reason, even non-animated GIFs cause repeated reflows). I simply avoid the
reflows if the image size is fixed since any changes in the image size are
irrelevant.
Most of the testcases in this bug don't involve animated images... 

Even if that fix takes care of all the testcases in this bug, we should still 
make sure that a reflow caused by some other change on the page wouldn't cause 
an image to be reloaded from the server.
I'm pretty sure bug 63750 is a dup of this bug, so copying perf and topperf 
from that bug.
Keywords: perf, topperf
Updated status whiteboard.

CC'ing pavlov.
Pav: Does the new imagelib fix this bug?
Whiteboard: This bug is probably a dup of another topperf bug 69534 which is fixed by the new imagelib
Summary: gif img in table with width=100% blinks rapidly (flashes, flickers) (can happen without tables) → gif img in table with width=100% blinks rapidly (flashes, flickers) (can happen without tables) [layout]
yes, this will be fixed.
Updated status
Whiteboard: This bug is probably a dup of another topperf bug 69534 which is fixed by the new imagelib → This is fixed by the new imagelib
Blocks: 71668
That's weird.  The image itself blinks!  Is this a GIF animation problem for
this example?

     http://ksi.ii.uj.edu.pl/images/instytut.gif

piotr@pingu.ii.uj.edu.pl, did you try the URL that I mentioned here on 2/21/00?
 (I still get shrinking images on this 2001031208 build...)
Probabely fixed by the fix to 69534... Please check.

tested http://www.nor.no and http://news.gnome.org/gnome-news w/ linux build
from 0317. I used to see the "flashing lines" and they no longer flash now.

Some kind of problem seems to remain though:
Those pages don't finish loading untill a timeout seemingly triggers after
nearly 3 minutes. (Throbber keeps throbbing etc. but there is no network traffic.)
This final timeout happens when socket enter TIME_WAIT state. First then does
the throbber stop / progress-meter reset.

Throbber not stopping is prob bug 39310.
I tested more of the sites that are dups/testcases of this bug:
*ALL* of them now show the same behaviour: throbber and progress-meter doesn't
reset til some timeout occurs. This at worst means 3 minutes of idle waiting, to
see if something more "happens to load". Totally unacceptable.
Take a look at the minimal testcase in this bug for instance:
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=15369

What happens in these cases is that the TCP socket remains in state ESTABLISHED
for far too long. Why doesn't it go TIME_WAIT or even close when the page has
loaded?
Sockets remaining open isn't necessarily a bug (HTTP/1.1 performance benefits
come in part from not doing too many SYN/SYN|ACK/ACK dances with the same
server, and sockets might be staying open to handle that)

Throbber not stopping is one of the children of bug 39310. Look there.
Resolving as fixed.
remaining issues are covered by bug 39310
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Marking verified in the April 10th build.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: