[dashboard][shipping] diff links in pushes view should base off of accepted signoff instead of pending

RESOLVED FIXED

Status

Mozilla Localizations
Infrastructure
P1
normal
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: Pike, Assigned: gandalf)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

9 years ago
Right now, if there's a pending sign-off, the diff links are wrt that sign-off instead of wrt the last accepted sign-off.

That makes reviewing sign-offs hard.
(Reporter)

Comment 1

9 years ago
Fixing this naively (did that locally) breaks everything.

We might want to have this depend on the signoffs-factorization bug, fwiw. I'll try to hack on that one in a way that that's feasible.

I wish the pushes view wouldn't be so slow locally. We query the hell for each push loaded, apparently.
(Reporter)

Updated

9 years ago
Priority: -- → P1
(Assignee)

Comment 2

9 years ago
http://hg.mozilla.org/l10n/django-site/rev/e2bc64d33a4c

fixed it almost naively, but without breaking the foundations of the universe... I hope.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

9 years ago
Reopening, http://bm-l10n-dashboard01/stage/shipping/pushes?locale=gl&av=fx3.5 shows a diff link on an accepted signoff. Not sure why, can you investigate?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 4

9 years ago
Also, it offers a diff link if there's only one pending signoff, with from= nothing.
(Assignee)

Comment 5

9 years ago
http://hg.mozilla.org/l10n/django-site/rev/d268b7c7fefb
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Assignee: nobody → gandalf
(Reporter)

Updated

8 years ago
Summary: [dashboard] diff links in pushes view should base off of accepted signoff instead of pending → [dashboard][shipping] diff links in pushes view should base off of accepted signoff instead of pending
You need to log in before you can comment on or make changes to this bug.