528047 - Move loadFileToString to IOUtils.js

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch

Please get to reviewing this at your leisure.

Comment 1

[David :Bienvenu]

Comment on attachment 411807 [details] [diff] [review]
patch

you've removed the crazy, so you can remove that part of the comment:

+// We need loadFileToString from here, and honestly this is no crazier a
+// dependency than gloda's Log4Moz

Comment 2

[Rain [:rain1] (inactive)]

Well, I felt it was still sort of crazy (though less crazy than before), but I'll remove it.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 411807 [details] [diff] [review]
patch

Thank you for undertaking this cleanup effort.

I don't think MailUtils is a good place for this.  I'm worried about MailUtils becoming a dumping ground and bloating.

I suggest we create either a FileUtils or IOUtils and do it in mailnews like we have for fixIterator.  That also avoids the code duplication that seems silly for file stuff.

Comment 4

[Karsten Düsterloh]

Comment on attachment 411807 [details] [diff] [review]
patch

I explicitly agree with asuth's comment #3.

Comment 5

[Rain [:rain1] (inactive)]

Attachment: patch, now with IOUtils

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 415852 [details] [diff] [review]
patch, now with IOUtils

danke!

Comment 7

[David :Bienvenu]

Comment on attachment 415852 [details] [diff] [review]
patch, now with IOUtils

I probably would have gone with FileUtils, but I won't quibble :-)

Comment 8

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/b338e03884fb