528161 - Active Daily Users 0

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Statistics, defect, P5)

Description

[Alexander Bergmann]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: 

For my Thunderbird Extension "Mail Merge" daily users are 0 although there are already over 100 downloads and I have
installed the extension myself. I think that possibly the update pings are related to one of the two duplicate add-ons that have been deleted: https://bugzilla.mozilla.org/show_bug.cgi?id=518064

https://addons.mozilla.org/de/thunderbird/addon/47144 (correct)
https://addons.mozilla.org/de/thunderbird/addon/47143
https://addons.mozilla.org/de/thunderbird/addon/47142

(In Bug https://bugzilla.mozilla.org/show_bug.cgi?id=435075 the same problem is described.)


Reproducible: Always

Comment 1

[Fred Wenzel [:wenzel]]

Fligtar, do you know how this happens? The duplicates do not have the same GUID anymore since we fixed dupes last week, but I am wondering what it takes for the numbers to pick up on the real add-on.

Comment 2

[Justin Scott [:fligtar]]

If there's only one GUID, any update pings should be associated with it. I don't have any ideas here.

Comment 3

[Alexander Bergmann]

Are update pings for [e-mail] registered? If they are, then they are obviously not counted at all or related to another add-on. As "Active Daily Users" is still 0 and "no data yet"!

(It is really disappointing not to have the statistics for active daily users.)

Comment 4

[Fred Wenzel [:wenzel]]

Okay, so I do have some entries in the update_counts table, all of which are associated with the 47143. Daniel, aren't the update_counts populated by metrics? Does metrics maybe have an old guid->addon_id mapping?

Comment 5

[Fred Wenzel [:wenzel]]

(In reply to comment #0)
> For my Thunderbird Extension "Mail Merge" daily users are 0 although there are
> already over 100 downloads and I have
> installed the extension myself.

Just a quick heads-up to not leave you hanging here: From what the database spits out, you have between 50 and 70 users a day.

Comment 6

[Daniel Einspanjer [:dre] [:deinspanjer]]

My code that retrieves and stores the add-on information from the AMO database was just not designed with the possibility of multiple addon_ids with the same GUID in mind.  The lookup step would grab the last addon_id in my lookup table according to the natural ordering.  That was 47143.

I've put a stop gap measure in to order the lookup by addon_id such that the highest addon_id number should be selected.  I'll have to investigate further what sort of cleanup is required to correct this issue.

Comment 7

[Fred Wenzel [:wenzel]]

Daniel: Thanks for helping to clean up the problem. This was caused by bug 518064, which was supposed to be fixed awhile ago, but something went wrong during the deployment. The problem is now resolved. To make this clear: Duplicate GUIDs are now impossible.

So, we either have to re-process some logs with the right IDs, or you update your lookup table to represent the current data, and the counts will be right for the affected add-ons from now on.

Comment 8

[Daniel Einspanjer [:dre] [:deinspanjer]]

Understood.  I'll try to take some time next week to look at the bad data in the DB and see if it can easily be corrected via cleanup queries vs the pain of having to reprocess.

Comment 9

[Alexander Bergmann]

Thank you very much so far! Now I do have Active Daily Users data since 15th November. But I discovered that I am missing Download Source data as well!

Comment 10

[Alexander Bergmann]

Active Daily Users and Download Source works after my Add-on has become stable!

Comment 11

[Tammo van Lessen]

Hi,

It looks like I'm running into the same issue. My add-on [1] has about 600 downloads but always shows up with zero (0) "active users", in the stats as well as on search result pages [2]. This seems to be a little odd since I have installed the addon myself.

Could you please check what is happening there and reopen this ticket (I could not find any way to reopen it by myself).

Thanks,
  Tammo

[1] https://addons.mozilla.org/en-US/thunderbird/addon/personal-level-indicators/
[2] https://addons.mozilla.org/en-US/thunderbird/search/?q=personal+indicator

Comment 12

[Jeff Balogh (:jbalogh)]

Tammo: we don't have any recorded active users for your add-on. I checked some other thunderbird add-ons like Lightning and Extra Folder Columns and they have active user counts, so I don't think it's a bug checking thunderbird user counts.

mysql> select * from update_counts where addon_id=310118;                        
Empty set (0.00 sec)

Comment 13

[Tammo van Lessen]

Jeff, thanks for your reply. I remember that I also had created a duplicate when creating the addon, could you please check if there are user counts for 309971? If this does not help, do you have any hints for me to debug? I mean, if there are ~660 downloads, and at least myself is using the add-on, there should be update pings, no? I tried to find the update ping with wireshark, without any luck since its HTTPS. Any advice is highly appreciated.

Comment 14

[Tammo van Lessen]

Meanwhile I gathered some information from the console:

*** EM_LOG *** Datasource: Addon Update Started: [e-mail]
*** EM_LOG *** RDFItemUpdater:checkForUpdates sending a request to server for: https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=[e-mail]&version=0.5&maxAppVersion=3.1.*&status=userEnabled&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}&appVersion=3.1.11&appOS=WINNT&appABI=x86-msvc&locale=en-US&currentAppVersion=3.1.11&updateType=97, item = ({id:"[e-mail]", version:"0.5", installLocationKey:"app-profile", minAppVersion:"3.1", maxAppVersion:"3.1.*", name:"Personal Level Indicators", xpiURL:"", xpiHash:"", iconURL:"chrome://pli.taval.de/skin/icon.png", updateRDF:"", updateKey:"", type:2, targetAppID:"{3550f703-e582-4d05-9a08-453d09bdfdc6}"})

When I open this URL in my browser the response looks okay, also the add-on ID looks okay. Which makes me even less understanding why the count is always 0.

Comment 15

[Tammo van Lessen]

The "active users" count is still zero, although I ran "check for updates" a couple of times and also opened the URL in #14 in a browser. To the stats counter should have definitely been hit. Now the question would be: Why doesn't it find its way into the DB?

How should I proceed? Should I open another bug since it seems to be a different problem (actually it is the same problem but probably a different situation/cause)? It a little bit annoying to see these wrong numbers.

Comment 16

[Daniel Einspanjer [:dre] [:deinspanjer]]

I have seen a problem that sounds like this before. It happened when there was a duplicate version of the addon and we report the usage under the wrong id.  Could someone from amo search the db for that other id and see if there is adu for it?  I am out of the office until wednesday dealing with family issues. I will work on this when I get back though.

Comment 17

[Jeff Balogh (:jbalogh)]

There's only one addon with the guid | [e-mail] |

Comment 18

[Tammo van Lessen]

Daniel,

thanks for your offer. Have you had already a chance to look it this? Your help is much appreciated. Thanks,
  Tammo

Comment 19

[Daniel Einspanjer [:dre] [:deinspanjer]]

I'm sorry, I was working on a different bug that had a similar title to this and didn't realize there were two separate ones until your ping last night.  I will implement the fix for your addon today and then after the export tonight, I will get Wil to run an update statement on the amo database to fix the historic data.

Comment 20

[Daniel Einspanjer [:dre] [:deinspanjer]]

Updated the metrics database and opened bug 670980 for the AMO team to update their database after the export tonight.

Comment 21

[Tammo van Lessen]

Awesome, many thanks for your support!