Closed Bug 528176 Opened 11 years ago Closed 6 years ago

[sr] Choose search plug-ins for Fennec in Serbian


(Mozilla Localizations :: sr / Serbian, defect)

Not set


(Not tracked)



(Reporter: stas, Unassigned)



(Keywords: productization, Whiteboard: [bootstrapped][twitter])


(2 files)

You've indicated an interest in participating in the localization of mobile Firefox (aka Fennec). We want to ship Fennec with a good list of search engines for Serbian. As the technical details of implementation are being worked on, we'd like to start the discussion about the choice of search engines. This bug is about agreeing on a set of search engines, and will not tackle the implementation (at least not yet).

First, the localization team and Staś will look at the market for the locale and come up with a good set of search providers. The guidelines for making recommendations are on You're welcome to suggest engines already shipped in desktop Firefox for Serbian, if they fit well in the categories outlined on the wiki.

For en-US, we currently use the following set, which may serve as an inspiration:
Google, Wikipedia, Amazon, Yahoo, Twitter.

Note that according to the guidelines, for some categories it may be better to leave them empty than to ship with en engine that's irrelevant or unavailable in your region.

After we decided on a particular search engine, we will need to test it in Fennec. You can test on a mobile device and on the desktop (download the builds from <>). Staś will help with testing on a device, too. If the service works fine, Staś will contact the owner and ask for permission, and for specifics like proper search flags. We'll likely need your help to at least get the contact information if we don't have them already.

We don't know the implementation details yet, so for now, please don't create patches nor land anything. We will keep you posted as we figure out the how's and when's.

Just a friendly reminder, as we move closer to the general availability date for Fennec in mid-December, have you had any chance to consider search providers?  Thanks!
Hello Staś, and thanks for a reminder. I was thinking about adding these:

Wikipedia (in Serbian)
Pogodak or Krstarica

I'm sure you know about first two, so I`ll skip to 3rd and 4th. 

Both Pogodak and Krstarica are search engines, distributing mainly results in Serbian. Pogodak is currently used in Firefox sr, but I think Krstarica is better option for us because it has, among search engine, many other free services, and is well known web portal in Serbia(probably the one of oldest and according to Google the one with most visits).

Vokabular is free dictionary service, pretty popular in Serbia.

Anyway, I thought I may test those on my linux box later this evening, but I would appreciate if you could do a few tests for me on a mobile device.
Hey Milos, thanks for the comments. Any thoughts on social search? Would you recommend including Twitter?
Erm, I'm more for a facebook, it's more popular than twitter in Serbia.
Here's a patch resetting the mobile/searchplugins/ directory to a minimal set of search engines that we would like to ship your locale with. Please read this comment carefully before you land this patch.

*Important*: There has been a change to how we use the  <Description/> elements present in the plug-ins (see bug 528655 and bug 529869). We want to emphasize that the search is integrated with the browser to better reflect what a search plugin is and what it does. You will need to edit the Wikipedia plug-in before you commit this patch. Please read <> for detailed instructions.

For Google, we don't have to copy the XML file to your mobile/searchplugins/ directory. Plugins identical to en-US are pulled from source automatically. It's enough to put the engine's name in list.txt for this to work (which I did). I also updated the Wikipedia plug-in to use a bigger icon, see bug 517997 for details.

Please edit the Wikipedia plug-in and commit this patch before you opt-in in the newsgroup. Opt-ins without this patch will not be taken. This does not mean that we don't want to include other search engines. On the contrary, the work and the discussion will continue in this bug until we choose a good set of search engines for your locale. Then, you will be able to opt in again, so that in the final release we include more search engines than the mineral set from this patch.

This patch is simply meant to reset your mobile/searchplugins directory so that we keep the repository clean and happy.

Thanks for understanding!
Here's the patch I'll commit after :stas review it. Just to explain:

<Description>  Интегрисана претрага српске Википедије</Description>

could be roughly translated as:

<Description>  Integrated Serbian Wikipedia search</Description>

Patch is ready to go whenever I get green light.
Attachment #414702 - Flags: review?(stas)
Comment on attachment 414702 [details] [diff] [review]
Wikipedia-sr description changes

Thanks Milos, that looks good. Two minor things:

>+  <Description>  Интегрисана претрага српске Википедије</Description>

Any reason for having the leading "  " in front of "Интегрисана"?

>+<Image width="16" height="16">

That was in my patch too, but can you please indent this line with two spaces to match other lines in the plugin?

r=me with these addressed, please land it.
Attachment #414702 - Flags: review?(stas) → review+
Fixed everything as per comment 7, and marking this bug fixed.

If needed, please reopen it. Else, please make it verified.

Closed: 11 years ago
Resolution: --- → FIXED
Reopening, we still need to make the call about:

Resolution: FIXED → ---
Whiteboard: [bootstrapped][twitter]
This bug landed ages ago. For clarity I think we'll need a new bug to set-up searchplugins on Fennec for Serbian as soon as the localization is up to speed, the current set of 2 searchplugins is definitely not enough.
Closed: 11 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.