Closed
Bug 528195
Opened 16 years ago
Closed 10 years ago
[shipping] Remove "Shipped in" display and logic
Categories
(Webtools Graveyard :: Elmo, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: Pike)
References
()
Details
Attachments
(1 file)
|
2.57 KB,
patch
|
adrian
:
review+
|
Details | Diff | Splinter Review |
I have added a limited amount of "shipped-in" information to the sign-off dashboards, but it's really not convincing just yet.
Maybe a hierarchical facet would help. I'd love to be able to make the facet go from "shipped-in" to "not-shipped-in" for some milestones to be actually useful. The latter seems to be really tough, though.
Not sure if it'd help to have a graph, I'm thinking about a flow of streams. The timeline view that stas has didn't rock the boat for me.
|
Assignee | |
Comment 1•15 years ago
|
||
I improved this a bit with pages like https://l10n-stage-sj.mozilla.org/shipping/app/locale-changes/fx3.5 and https://l10n-stage-sj.mozilla.org/shipping/about-milestone/fx3.5.6.
Those aren't hooked up anywhere yet, where should those be linked from?
|
|
Assignee | |
Updated•15 years ago
|
Priority: -- → P3
Whiteboard: [needs navigation]
|
|
Assignee | |
Updated•14 years ago
|
Component: Infrastructure → Elmo
Product: Mozilla Localizations → Webtools
QA Contact: infrastructure → elmo
Summary: [dashboard] Improve "Shipped in" display and logic → [shipping] Improve "Shipped in" display and logic
Version: unspecified → 1.0
|
|
Assignee | |
Comment 2•11 years ago
|
||
Morphing this bug, to actually just clean this up by removal.
Mentor: l10n
Priority: P3 → P2
Summary: [shipping] Improve "Shipped in" display and logic → [shipping] Remove "Shipped in" display and logic
Whiteboard: [needs navigation] → [good-first-bug]
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [good-first-bug] → [good-first-bug][shipping.status.StatusJSON.get_signoffs]
|
|
Assignee | |
Comment 3•11 years ago
|
||
I'm working on this as part of bug 1111570, taking.
Status: NEW → ASSIGNED
QA Contact: l10n
Whiteboard: [good-first-bug][shipping.status.StatusJSON.get_signoffs]
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → l10n
Mentor: l10n
QA Contact: l10n
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8544097 -
Flags: review?(adrian)
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8544097 [details] [diff] [review]
remove shipped-in logic
Tested locally, seems to work correctly.
Attachment #8544097 -
Flags: review?(adrian) → review+
|
||
Comment 6•11 years ago
|
||
Commit pushed to develop at https://github.com/mozilla/elmo
https://github.com/mozilla/elmo/commit/0d78bde48881cd5af610a95fd3f0e0dfcfde7f88
bug 528195, remove shipped-in logic, it's useless these days, r=adrian
|
|
Assignee | |
Comment 7•10 years ago
|
||
This is deployed in prod, marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Comment 8•10 years ago
|
||
Commit pushed to develop at https://github.com/mozilla/elmo
https://github.com/mozilla/elmo/commit/5c660f12dddb6014242f0f8aa32b097e852a369b
bug 528195, remove dead code I forgot back then.
|
|
Assignee | |
Comment 9•10 years ago
|
||
I forgot a bunch of dead code, landed a follow-up.
|
|
||
Comment 10•10 years ago
|
||
Commit pushed to develop at https://github.com/mozilla/elmo
https://github.com/mozilla/elmo/commit/7d79f4bbeb902ab4f94fa49066224861c7411d5a
bug 528195, follow up tests
Make sure AppVer4Tree items are sorted, and that we're only
retrieving trees that are having sign-offs enabled and an
appversion
|
||
Updated•5 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•