Closed Bug 528222 Opened 11 years ago Closed 11 years ago

Android: fix avmplus compiler warnings on gcc-4.4.0

Categories

(Tamarin Graveyard :: Virtual Machine, defect, minor)

Other
Linux
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: cpeterson, Unassigned)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 (.NET CLR 3.5.30729)
Build Identifier: 

Change 601988 by chrispet@chrispet-mac on 2009/11/11 17:09:39

Severity: low
Summary: Android: fix debug build warnings in avmplus
Description: Android's gcc-4.4.0 does not honor "#pragma GCC diagnostic warning", so "fix" the bogus warning by reordering the ||'d expressions.

../../../third_party/avmplus/core/Traits.cpp: In member function 'uint32_t avmplus::Traits::computeSlotAreaStart(uint32_t, uint32_t, uint32_t) const':
../../../third_party/avmplus/core/Traits.cpp:1078: warning: logical '||' with non-zero constant will always evaluate as true

< AvmAssert(((result % 8) == 0) || (nPointerSlots == 0) || (!alignPointersTo8Bytes));
> AvmAssert( ((result % 8) == 0) || (!alignPointersTo8Bytes) || (nPointerSlots == 0) );

Reviewer: Steven

Affected files ...

.. //depot/users/FlashRuntime/Android/code/third_party/avmplus/core/Traits.cpp#12 edit

Reproducible: Always
Attached patch Traits.cpp patchSplinter Review
Attachment #411988 - Attachment mime type: application/octet-stream → text/plain
Attachment #411988 - Flags: review?(rreitmai)
Comment on attachment 411988 [details] [diff] [review]
Traits.cpp patch

oops, I should probably review this
Attachment #411988 - Attachment is patch: true
Attachment #411988 - Flags: superreview?(edwsmith)
Attachment #411988 - Flags: review?(stejohns)
Attachment #411988 - Flags: review?(rreitmai)
Note that this patch assumes that https://bugzilla.mozilla.org/show_bug.cgi?id=512485 has already landed
Attachment #411988 - Flags: superreview?(edwsmith) → superreview+
Comment on attachment 411988 [details] [diff] [review]
Traits.cpp patch

Note, I will push this along with https://bugzilla.mozilla.org/show_bug.cgi?id=512485 whenever it lands
Attachment #411988 - Flags: review?(stejohns) → review+
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Engineering work item.  Marking as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.