Status

addons.mozilla.org Graveyard
Admin/Editor Tools
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: eviljeff, Assigned: jorgev)

Tracking

Details

(Whiteboard: [ReviewTeam])

(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1.4) Gecko/20091007 Firefox/3.5.4
Build Identifier: 

Some of the canned responses have gotten a little out of date and need replacing/amending.

The conduit response differs from our policy for example.

As per mailing list response from Jorge this bug will cover suggestions for changes.



Reproducible: Always

Updated

8 years ago
Assignee: nobody → jorge
OS: Windows XP → All
Hardware: x86 → All
Status: UNCONFIRMED → NEW
Ever confirmed: true
Hi.
I'm new at this, but I've encountered some suggestions to add for the canned responses:

Errors in the error console
While testing your add-on, the error console printed out these errors:

Empty/unused folders/files
You have empty folders/files or unused files in your add-on. Please remove them in your next release.

Use of eval() function
Your add-on is using an eval() function. We recommend using JSON parsing (https://developer.mozilla.org/en/JSON) in order to avoid security issues derived from the use of the eval() function.

More information for testing
Could you provide detailed information on how to test your add-on? Also, if there is an username/password combination necessary to test your add-on, could you specify that information too?

Comment 2

8 years ago
(In reply to comment #1)
> Use of eval() function
> Your add-on is using an eval() function. We recommend using JSON parsing
> (https://developer.mozilla.org/en/JSON) in order to avoid security issues
> derived from the use of the eval() function.

I'd also reference this post for this:
http://adblockplus.org/blog/five-wrong-reasons-to-use-eval-in-an-extension

The eval might be used on other types of data, not just JSON.
As Jose Enrique's suggestion:

Needs more downloads/user reviews:
Your add-on numbers are a little low now to merit approval. Try to promote your add-on as best as you can, so that you can get some downloads and user reviews that convince us that it will be useful to a wider audience.
(Reporter)

Comment 4

8 years ago
(from a list conversation last week)

For the numerous Youtube mp4 downloading addons:

"Dear Addon developer,
thanks for contributing your addon but its functionality is already available in many existing addons so making it public would not enhance our users experience. 
thanks"

criteria for use from Jorge -

We'll be rejecting add-ons that:
1) Offer youtube / flash video / flv / mp4 downloading for popular video sites.
2) Don't offer any value on top of that. I know there are a few more sophisticated add-ons that offer re-encoding and such, so that may be good to have.
(Reporter)

Comment 5

8 years ago
(In reply to comment #1)
> Use of eval() function
> Your add-on is using an eval() function. We recommend using JSON parsing
> (https://developer.mozilla.org/en/JSON) in order to avoid security issues
> derived from the use of the eval() function.

I normally include this link instead: https://developer.mozilla.org/en/Downloading_JSON_and_JavaScript_in_extensions
(Assignee)

Comment 6

8 years ago
Fixed. Any other suggestions can be resolved via email.
As a side note, I've filed bug 530692 and bug 530691 to improve the canned response experience.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Whiteboard: [required amo-editors]

Comment 7

8 years ago
The 'Add-on not generally useful' response seems to have a grammar error. The part...

"so we have your entry for now"

... doesn't make sense and I am not sure what it is supposed to be saying.
probably "so we have *sandboxed* your entry for now"?
(Assignee)

Comment 9

8 years ago
Changed to "so we have rejected your entry for now". Thanks.
(Assignee)

Comment 10

6 years ago
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.