528318 - redirect %LOCALE%/firefox/getpersonas to getpersonas.com

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Nick Nguyen [:osunick]]

Fx 3.6 will point to AMO via a 'get themes' link in the extensions manager.  Initially, this link should point to http://www.getpersonas.com/%LOCALE%/gallery/All/Popular

Suneel, is this the right link we should point to?

/personas should continue to go to the gallery.

Comment 1

[Wil Clouser [:clouserw]]

This should be:

%LOCALE%/firefox/getpersonas on the AMO side

Comment 2

[Wil Clouser [:clouserw]]

Sancus said he could get to this early this week.  If not, I'll take it back after weds.

Comment 3

[Andrei Hajdukewycz [:sancus]]

Attachment: Firefox getpersonas redirect v1

This should work. There don't actually appear to be any localizations(other than en-US) on http://www.getperson as.com. They appear to fallback properly -- http://www.getpersonas.com/de/gallery/All/Popular -- for example, however, so that shouldn't affect this patch.

Comment 4

[Wil Clouser [:clouserw]]

> This should work. There don't actually appear to be any localizations(other
> than en-US) on http://www.getperson as.com. They appear to fallback properly --
> http://www.getpersonas.com/de/gallery/All/Popular -- for example, however, so
> that shouldn't affect this patch.

That is a weird fallback.  Apparently it doesn't look at the locale:  http://www.getpersonas.com/en-US/something/fishy/is/going/on/with/this/crazy/URL/gallery/All/Popular .  Anyway, that's not this bug.

Comment 5

[Wil Clouser [:clouserw]]

Comment on attachment 412943 [details] [diff] [review]
Firefox getpersonas redirect v1

I think this would be easier to do in the .htaccess, but this will work.  Thanks for the patch, r56251

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

* https://preview.addons.mozilla.org/en-US/firefox/getpersonas, which redirects to http://www.getpersonas.com/en-US/gallery/All/Popular
* https://preview.addons.mozilla.org/de/firefox/getpersonas, which redirects to http://www.getpersonas.com/en-US/de/gallery/All/Popular

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Actually, I need to reopen this; we shouldn't be redirecting https://preview.addons.mozilla.org/de/firefox/getpersonas to http://www.getpersonas.com/en-US/de/gallery/All/Popular; it should be http://www.getpersonas.com/de/gallery/All/Popular

Comment 8

[Andrei Hajdukewycz [:sancus]]

It is being redirected to http://www.getpersonas.com/de/gallery/All/Popular, the getpersonas funky alias code rewrites it because there are no valid locales other than en-US.

Comment 9

[Wil Clouser [:clouserw]]

Like Andrei said, the weird redirect is on their end.  We're going to the URL they wanted,

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Sorry guys, you're right; http://web-sniffer.net/?url=https%3A%2F%2Fpreview.addons.mozilla.org%2Fde%2Ffirefox%2Fgetpersonas&submit=Submit&http=1.1&gzip=yes&type=GET&uak=0 confirms that it's a 302 to the right page.

Comment 11

[Justin Scott [:fligtar]]

This bug was pushed live off-cycle tonight.