52839 - Mail and News dirs are being counted twice in space required computations

Status: VERIFIED FIXED

(Core Graveyard :: Profile: Migration, defect, P1)

Description

[dbragg]

The Mail and News directories are being counted twice when disk space 
requirements are computed for migration.  The reason is that a PR_TRUE is being 
passed to the GetSizes() function for the Profile directory itself.  This tells 
the function to traverse subdirectories.  This should only be done on the Mail 
and News directories explicitly.  

When applied to the Profile directory, it traverses the Mail and News 
directories as well as any other directory the user may have.  Then when 
GetSizes is called for the Mail and News directories they are counted again.

Fix in hand.  (Just passing an PR_FALSE instead of a PR_TRUE as the second 
parameter to GetSizes().

Comment 1

[Daniel Veditz [:dveditz]]

Approving nsbeta3+ and assigning P1: if a user has a lot of mail we could 
erroneously think we don't have enough diskspace and then fail to migrate their 
profile, "losing" their mail etc (from their POV).

Comment 2

[dbragg]

Attachment: Diff of nsPrefMigration.cpp

Comment 3

[Bill Law]

a=[e-mail]

Good work following those new rules!

Comment 4

[racham]

That looks right to me. r=bhuvan.

Good catch...! Particularly, after knowing the fact that the cache folder would
also get counted into the total size....?

Comment 5

[dbragg]

Fixed as described.

Comment 6

[Grace Bush]

verified code fix