Enhanced Localization (phase 1)

RESOLVED FIXED in 5.4

Status

defect
P1
normal
RESOLVED FIXED
10 years ago
3 years ago

People

(Reporter: osunick, Assigned: davedash)

Tracking

unspecified
x86
macOS
Bug Flags:
in-testsuite ?
in-litmus ?

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

10 years ago
No description provided.
Reporter

Updated

10 years ago
Priority: -- → P1
Summary: Enhanced Localization → Enhanced Localization (phase 1)
This bug is for phase 1
Reporter

Updated

10 years ago
Assignee: nobody → dd
"We've identified a need in several markets (particularly where English is not generally understood) for the ability to filter AMO for specific locales.  For instance, in JA, there should be a checkbox (checked by default but remembered on a per browser basis) that filters all search, collection, and listing content by whether or not they contain JA specific translations.
"

We're doing this in search now.  We back fill other locales.

The browse view... this could get very gross... we could do backfilling here, or something else... but this might need to be chowsed it's got a lot of checkboxes and will just get fugly.
Posted patch v1 (obsolete) — Splinter Review
Adds a checkbox to the browse view.

Stephen/Krupa,

This should be in Litmus for sure, but I can't figure out a useful automated test (until we move it over to Django), my automation idea is just verifying that we're looking at ja translations if we went to a /ja/ brows page:

/ja/firefox/browse/type:1/cat:all?show=20&locale-only=on&sort=newest

That we verify that all the translations we're seeing are ja-only.
Attachment #414095 - Flags: review?(clouserw)
Dave: there's a flag for that (tm); marked :-)
Flags: in-testsuite?
Flags: in-litmus?
Comment on attachment 414095 [details] [diff] [review]
v1

I'm fine with the code, but the UI wording is confusing (I wish I would have noticed the wording of the "show Firefox-only add-ons" too).  I think that makes it more difficult for L10n, why not just:

Show only $lang add-ons

Also, you can add the complete locale name to an abbr or alt tag.  Use localeDetails::getNativeNameForLocale()
Attachment #414095 - Flags: review?(clouserw) → review-
Posted patch v2Splinter Review
Didn't feel like converting localeDetails to static, but this works.
Attachment #414095 - Attachment is obsolete: true
Attachment #414120 - Flags: review?(clouserw)
Comment on attachment 414120 [details] [diff] [review]
v2

That works too
Attachment #414120 - Flags: review?(clouserw) → review+
r56724 | ddash@mozilla.com | 2009-11-23 15:25:20 -0800 (Mon, 23 Nov 2009) | 2 li

[bug 528391] Addeda  checkbox
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.