528407 - jemalloc.c will not compile on Solaris 10 due to use of stdbool.h

Status: RESOLVED WONTFIX

(Core :: Memory Allocator, defect)

Description

[Jeff Wieland]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8.1.23) Gecko/20090908 SeaMonkey/1.1.18 Firefox/2.0
Build Identifier: http://releases.mozilla.org/pub/mozilla.org/seamonkey/releases/2.0/source/seamonkey-2.0.source.tar.bz2

When compiling under Solaris 10 with Sun Studio 12, I get the following error:


Reproducible: Always

Steps to Reproduce:
1. Just try to build as normal.

Actual Results:  
Building deps for /scratch/wieland/src/seamonkey2/2.0/comm-1.9.1/mozilla/memory/jemalloc/jemalloc.c using Sun Studio cc
"/usr/include/stdbool.h", line 42: #error: "Use of <stdbool.h> is valid only in
a c99 compilation environment."
cc: acomp failed for /scratch/wieland/src/seamonkey2/2.0/comm-1.9.1/mozilla/memory/jemalloc/jemalloc.c

Expected Results:  
It should just compile :-)

I can work around by copying the system stdbool.h somewhere that the compilers find first and editing it slightly to create the _Bool type.

Comment 1

[Ginn Chen]

I'm not sure if it worths a fix.
You can copy stdbool.h from OpenSolaris to your S10 machine.

Perhaps change
#if defined(_STDC_C99)
to
#if defined(_STDC_C99) || defined(__C99FEATURES__) || __GNUC__ >= 3

I vote WONTFIX to make the source code clean.