528430 - Add a directory provider so we can customize the cache folder at runtime

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

For Maemo, the N8xx has a large partition on /media/mmc2, while the N900 has a large /home partition (where we store the profile). We can't use preprocessed preferences to switch these at build time.

This patch adds a directory service provider that checks the hardware at runtime and supplies the best folder location for the main cache and the offline cache.

It defaults to the profile folder for unknown hardware.

(I also use this chance to make all JS components use the same naming convention, which appears to be no leading 'ns' and leading uppercase)

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

seems like this could be useful for products other than Fennec, why not implement this in the platform?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)
> seems like this could be useful for products other than Fennec, why not
> implement this in the platform?

I think this is too Fennec specific to be in the platform itself. If we were going to put it in the platform, I don't think it would be a directory service provider. It would just be in the CacheService code. The differences in location based on hardware are too fickle for the platform, IMO. This seems perfect for an application-level dir provider.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/92006c81c46f