Closed Bug 528430 Opened 10 years ago Closed 10 years ago

Add a directory provider so we can customize the cache folder at runtime

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
fennec1.0

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
For Maemo, the N8xx has a large partition on /media/mmc2, while the N900 has a large /home partition (where we store the profile). We can't use preprocessed preferences to switch these at build time.

This patch adds a directory service provider that checks the hardware at runtime and supplies the best folder location for the main cache and the offline cache.

It defaults to the profile folder for unknown hardware.

(I also use this chance to make all JS components use the same naming convention, which appears to be no leading 'ns' and leading uppercase)
Attachment #412145 - Flags: review?(bugmail)
tracking-fennec: --- → ?
Assignee: nobody → mark.finkle
seems like this could be useful for products other than Fennec, why not implement this in the platform?
(In reply to comment #1)
> seems like this could be useful for products other than Fennec, why not
> implement this in the platform?

I think this is too Fennec specific to be in the platform itself. If we were going to put it in the platform, I don't think it would be a directory service provider. It would just be in the CacheService code. The differences in location based on hardware are too fickle for the platform, IMO. This seems perfect for an application-level dir provider.
Attachment #412145 - Flags: review?(bugmail) → review+
pushed:
https://hg.mozilla.org/mobile-browser/rev/92006c81c46f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.