528471 - Toolbar buttons added with navBar.insertItem disappear on restart

Status: RESOLVED INVALID

(Firefox :: Extension Compatibility, defect, P1)

Description

[Mike Kaply [:mkaply]]

Create a new profile

Install TrackerWatcher (https://addons.mozilla.org/en-US/firefox/addon/14454)

If you don't see the icon on the toolbar, go to customize toolbar and drag it between home and the URL bar.

Install Jetpack.

Notice that the icon disappears.

It's back in customize toolbar.

Jetpack shouldn't be screwing with other add-ons.

Comment 1

[Brade]

This seems part of a larger problem where Jetpack completely resets firefox's toolbar to the default icons. After removing jetpack and restarting firefox, my customized toolbar returned.

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

I can confirm this issue with ff 3.5.5 on mac osx.

Comment 3

[Mike Kaply [:mkaply]]

Someone should really fix this quick.

JetPack is actually violating the AMO rules by doing this (even if it is just a bug).

If I don't see movement on this soon, I'm going to request JetPack be moved into the sandbox.

Comment 4

[Daniel Buchner [:dbuc]]

I just bumped the priority to the highest level, will talk to Atul today re: this issue.

Comment 5

[Mike Kaply [:mkaply]]

What is the status of this?

Comment 6

[Mike Kaply [:mkaply]]

Interesting. It's not Jetpack at all.

If you install any extension that adds a toolbar icon and then install another extension and use the Extension manager to restart, the icon goes away.

Firefox bog.

Comment 7

[Mike Kaply [:mkaply]]

It looks like if an extension uses navBar.insertitem to insert a toolbar button, it disappears on restart:

var navBar = document.getElementById("nav-bar");
var urlbarContainer = document.getElementById("urlbar-container");if (navBar && urlbarContainer) {
  navBar.insertItem("ID OF BUTTON IN TOOLBAR PALETTE", urlbarContainer);
}

Comment 8

[Mike Kaply [:mkaply]]

Continuing the conversation with myself.

In order for insertItem to work correctly, you have to explicitly update the attribute for currentset on the navBar (or whatever you are inserting into).

And then you have to document.persist it.

Didn't find any documentation on this on devmo.

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

Isn't this what you're looking for?

https://developer.mozilla.org/en/Code_snippets/Toolbar

Comment 10

[Philip Chee]

> In order for insertItem to work correctly, you have to explicitly update the
attribute for currentset on the navBar (or whatever you are inserting into).

> And then you have to document.persist it.

Um this is known. It has been discussed several times in Mozillazine and as jorgev points out *is* documented on DevMo.

Comment 11

[Mike Kaply [:mkaply]]

My bad. I did a myriad of searches and never found that code.