Closed Bug 528491 Opened 10 years ago Closed 10 years ago

Merge nsFocusController and nsWindowRoot

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

Attachments

(1 file)

Now that the focus manager exists, nsFocusController has only two purposes, one to store the current popupNode and the other for some command dispatching methods. For now, as both nsFocusController and nsWindowRoot are one-per-top-level-window, I'm going to combine them into nsWindowRoot and get rid of nsFocusController.

I hope to move the popupNode into some xul area in a later bug.
Attachment #412215 - Flags: superreview?(Olli.Pettay)
Attachment #412215 - Flags: review?(jst)
Attachment #412215 - Flags: superreview?(Olli.Pettay) → superreview+
Comment on attachment 412215 [details] [diff] [review]
merge files, passes all tests

>+nsGlobalWindow::GetTopWindowRoot()

Not the best name, but if it conflicts with the
existing GetWindowRoot, I don't have any better suggestions.
Comment on attachment 412215 [details] [diff] [review]
merge files, passes all tests

r=jst
Attachment #412215 - Flags: review?(jst) → review+
http://hg.mozilla.org/mozilla-central/rev/7463ca240288
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.