528545 - Change "Clear Recent History" to "Clear Private Data"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

In preferences, I think we should replace "Clear Recent History" with "Clear Private Data".  This is what the feature used to be called in desktop Firefox before, in 3.5, we added the ability to define a range of how far back we want to remove data and select what specifically you wan to remove, at which point it changed to "Clear Recent History."

Post-1.0 I think we'll want to give people the ability to have more control over what they delete and for what time range.  For now, I think the most basic and  important scenario is just resetting the browser to a "clean" state, which is what it does right now.

Clear Private Data, in pre-3.5 desktop firefox, did what the current "Clear recent history" feature does by default: it clears browsing and download history, form and search history, cookies you've accepted, your cache, and your currently active logins.  The logic here is that these are all things related to what you've been doing on the web, which is a reasonable match for most people's understanding of what "history" means.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

changes text

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

This patch works

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 412856 [details] [diff] [review]
patch 2

clearPrivateData2.title

I'm actually a bit worried now that I've reviewed this that this clears out saved passwords. I'm not sure whether that's expected of this button - about the only thing it doesn't clear out is bookmarks?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with entity name change:
https://hg.mozilla.org/mobile-browser/rev/52998210c57a

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b3pre) Gecko/20091118 Firefox/3.6b4pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091118 Firefox/3.7a1pre Fennec/1.0b5

This'll have to be updated in our litmus subgroups