Self-hosted add-on upload gives updateURL error

VERIFIED FIXED in 5.4

Status

addons.mozilla.org Graveyard
Developer Pages
P3
minor
VERIFIED FIXED
9 years ago
3 years ago

People

(Reporter: fligtar, Assigned: sancus)

Tracking

unspecified

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

9 years ago
There was a comment on our blog post that said when uploading an xpi to parse the install.rdf for a self-hosted add-on, it failed because the add-on had an updateURL. This is allowed for self-hosted add-ons.
Assignee: nobody → sancus
Severity: normal → minor
Priority: -- → P3
Target Milestone: --- → 5.4
(Assignee)

Comment 1

9 years ago
Created attachment 414124 [details] [diff] [review]
allow updateURL v1

This should do it. Something I noticed while working on this is that the entirely stand-alone Add-on Validator( https://addons.mozilla.org/en-US/developers/addon/validate ) also fails on this. Is that fine, or do you want that fixed also?
Attachment #414124 - Flags: review?(fligtar)
(Assignee)

Updated

9 years ago
Attachment #414124 - Flags: review?(fligtar)
(Assignee)

Comment 2

9 years ago
Created attachment 414138 [details] [diff] [review]
allow updateURL v2

now with fewer typos; still wondering about Add-on Validator though. This only changes the actual self-hosted add-on submission page.
Attachment #414124 - Attachment is obsolete: true
Attachment #414138 - Flags: review?(fligtar)
(Assignee)

Updated

9 years ago
Attachment #414138 - Flags: review?(fligtar) → review?(clouserw)
Comment on attachment 414138 [details] [diff] [review]
allow updateURL v2

I'll r+ this if you change isset() to actually checking for a '1'.  We might use addons.status for something else in the future.
Attachment #414138 - Flags: review?(clouserw) → review-
> Something I noticed while working on this is that the
> entirely stand-alone Add-on Validator(
> https://addons.mozilla.org/en-US/developers/addon/validate ) also fails on
> this. Is that fine, or do you want that fixed also?

I think having it fail on updateURL is fine.
(Assignee)

Comment 5

9 years ago
Created attachment 414844 [details] [diff] [review]
allow updateURL v3

No longer solely dependent on isset, although I kept an isset in because there's a bunch of cases where Add-ons get to this stage and don't have any status set at all and that throws notices otherwise.
Attachment #414138 - Attachment is obsolete: true
Attachment #414844 - Flags: review?(clouserw)
(Assignee)

Comment 6

9 years ago
Created attachment 414940 [details] [diff] [review]
allow updateURL v4
Attachment #414844 - Attachment is obsolete: true
Attachment #414940 - Flags: review?(clouserw)
Attachment #414844 - Flags: review?(clouserw)
thanks, r57008
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Jorge: is this something you're set up to test quicker than I?  If not, I'll verify it myself tonight; either way, thanks!
I don't think I can handle this today, but you can try the Google toolbar add-onb if you need one with an update url: http://dl.google.com/firefox/google-toolbar-beta-mac.xpi
Verified FIXED; submitted that one with a rev'd UUID:

Tested to ensure that it failed to upload when hosted via AMO, but self-listed works with:

    <em:updateURL><![CDATA[https://tools.google.com/firefox/update?guid=%ITEM_ID%&version=%ITEM_VERSION%&application=%APP_ID%&appversion=%APP_VERSION%&dist=google]]></em:updateURL>
Status: RESOLVED → VERIFIED
(Assignee)

Updated

9 years ago
Attachment #414940 - Flags: review?(clouserw)
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.