Closed Bug 528555 Opened 10 years ago Closed 10 years ago

[Regression] Addon Options Close when highlighting text in input fields

Categories

(Firefox for Android Graveyard :: General, defect, major)

Fennec 1.1
defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0

People

(Reporter: aakashd, Assigned: mfinkle)

Details

(Whiteboard: [fennecb5testday])

Attachments

(1 file)

Build Id:
Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b3pre) Gecko/20091113 Firefox/3.6b3pre Fennec/1.0b6pre


Steps to Reproduce:
1. Download and Install Weave onto fennec
2. Go to Options|Addons|Weave and click "Options"
3. type in text into one of the input fields
4. Mousedown and drag/pan to highlight the text

Actual Results:
The options area closes

Expected Results:
The options area shouldn't close and the text that was panned to should be highlighted
tracking-fennec: --- → ?
Whiteboard: [fennecb5testday]
Attached patch patchSplinter Review
We have an onselect listener that closed up any open options sections when the richlist selected item changed. Selecting text in a textbox was triggering the code.

Added code to test for the right onselect target
Assignee: nobody → mark.finkle
Attachment #412855 - Flags: review?(gavin.sharp)
Comment on attachment 412855 [details] [diff] [review]
patch

>diff --git a/chrome/content/browser.xul b/chrome/content/browser.xul

>-            <richlistbox id="addons-list" flex="1" onselect="ExtensionsView.hideOptions()">
>+            <richlistbox id="addons-list" flex="1">

how about having hideOptions take an optional event argument, and changing this to ExtensionsView.hideOptions(event)? Or just rename the handleEvent you added (hideOnSelect?) and call that. Declarative event listeners seem nicer.

r=me with that.
Attachment #412855 - Flags: review?(gavin.sharp) → review+
Changed to hideOnSelect(aEvent)

pushed:
https://hg.mozilla.org/mobile-browser/rev/1aadf6e58270
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b4pre) Gecko/20091123 Firefox/3.6b4pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091123 Firefox/3.7a1pre Fennec/1.0b5

Follow-up bug filed: https://bugzilla.mozilla.org/show_bug.cgi?id=530557
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.