528572 - Update product details for Firefox 3.6 Beta 3

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Axel Hecht [:Pike]]

We're taking more localizations for Firefox 3.6 Beta 3.

I'll be landing updates to shipped-locales and l10n-changesets_mozilla-1.9.2, filing this bug on www.mozilla.com right away to update product details based on that.

Comment 1

[Axel Hecht [:Pike]]

shipped-locale and l10n-changesets done, http://hg.mozilla.org/releases/mozilla-1.9.2/rev/5f8370a86737, http://hg.mozilla.org/build/buildbot-configs/rev/5f3524211d06.

Over to websites staff, the locale list is http://hg.mozilla.org/releases/mozilla-1.9.2/file/5f8370a86737/browser/locales/shipped-locales. Added:
cy, en-GB, eo, gu-IN, kk, kn, ko, mk, ml, nb-NO, nn-NO, si, sl, ta-LK

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Pascal, can we get a patch for the product-details?

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

What will be the release date? (for the FirefoxHistory class)

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: product-details patch

I am attaching the patch to product-details for review.

Note that this page does not update the History file for releases.

Comment 5

[Wil Clouser [:clouserw]]

Comment on attachment 412283 [details] [diff] [review]
product-details patch

wfm, we should add the history when we push it

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Please push this to trunk-stage; we're ready to start testing the download pages there.

Comment 7

[Wil Clouser [:clouserw]]

r56232

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Could we get these pushed live? Thanks!

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

I take that back. Hang on for now, please.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

And this seems to have gone live, at the appropriate time, so re-closing.

Comment 11

[Axel Hecht [:Pike]]

... reopened. Dance.

We're only showing 54 locales on all-beta.html, my suspect is that locales that only show in $beta_builds don't get picked up by all-beta.html. The LATEST_FIREFOX_DEVEL_VERSION of those probably needs to move up to $primary_builds. Guessing here only, though.

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: patch firefoxDetails.class.php to call all builds in all-beta.html

I looked at the class and the method used getDownloadTableForDevelBuilds() calls the primary_builds array.

I think that duplicating locales in both primary_builds and beta_builds is going to be error prone with our frequent stable/dev releases.

I would prefer getDownloadTableForDevelBuilds to use both arrays, here is a patch for that. I can land it on trunk for testing today if needed.

Comment 13

[Wil Clouser [:clouserw]]

Comment on attachment 413060 [details] [diff] [review]
patch firefoxDetails.class.php to call all builds in all-beta.html 

If that's what you would prefer, it's fine, but consistency would put another table underneath the primary one.  Beta build isn't the same as beta locale.

Comment 14

[Pascal Chevrel:pascalc (PTO until April 26)]

ok, committed in r56315

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

If it works, we should push it live ASAP.

Comment 16

[Vlado Valastiak [:wladow]]

One locale's still missing, it's 60 in the list vs 62-1 (ja/ja-jp-mac) in the shipped-locales

Comment 17

[Vlado Valastiak [:wladow]]

...and the missing locale is "or"

Comment 18

[Axel Hecht [:Pike]]

Yes, that's missing in firefoxDetails, in the beta builds. Probably missed out on that for Beta 2 as well.

Comment 19

[Pascal Chevrel:pascalc (PTO until April 26)]

Oriya added in r56376 on trunk

Comment 20

[Mike Beltzner [:beltzner, not reading bugmail]]

Can we, uh, please fix this? Don't think it blocks the release, but needs immediate attention.

Comment 21

[Wil Clouser [:clouserw]]

(In reply to comment #20)
> Can we, uh, please fix this? Don't think it blocks the release, but needs
> immediate attention.

If QA or y'all give me the thumbs up, I'll tag a new product details for production

Comment 22

[Stephen Donner [:stephend] Not actively reading bugmail]

Looks good to me: ran a link checker (http://validator.w3.org/checklink?uri=https%3A%2F%2Fwww-trunk.stage.mozilla.com%2Fen-US%2Ffirefox%2Fall.html&hide_type=all&depth=&check=Check), and the only broken link was to one mirror (hopefully Sentry catches that?)

It'd be nice if the QAE team could look over https://www-trunk.stage.mozilla.com/en-US/firefox/all.html too.

Comment 23

[Axel Hecht [:Pike]]

Will, seems like QA its deeds, can you push this live?

Comment 24

[Wil Clouser [:clouserw]]

done in production, r56597