52858 - Case where crash happens involving save to draft warning...

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P2)

Description

[laurel]

Using sept15 commercial build
linux rh6.0 and NT 4.0


I crash consistently when closing open message compose window, selecting any
option in save to draft warning dialog following these steps:

1.  From mail window, New Msg.
2.  Type an addressee, subject and body text having spelling errror(s).
3.  Click Spell Check button.  Spell check dialog opens identifying spelling
error... Click the spell check dialog's Xclose box.  Spell check dialog closes.
4.  Click the Xclose box in compose window. Save to draft warning appears.
5.  Click any of the buttons Cancel/Save/Don't Save in the draft warning dialog.

Result:  crash occurs.

Talkback stack(s) coming...

Comment 1

[laurel]

Attachment: talkback 17500369

Comment 2

[laurel]

Attachment: talkback 17432830

Comment 3

[laurel]

*** Bug 55050 has been marked as a duplicate of this bug. ***

Comment 4

[scottputterman]

nominating for rtm.  This crash seems like it will be pretty easy to reproduce
for people using the spell checker.

Comment 5

[scottputterman]

It seems that if you spell check this is a situation you might encounter a lot. 
 The stack doesn't look like mailnews code.  JF, if you don't think you are 
causing this, could you reassign.

Comment 6

[Simon Fraser [no longer active]]

Is this really linux only?

Comment 7

[scottputterman]

changed to all. Laurel's original comments say NT as well.

Comment 8

[selmer (gone)]

JF, can you comment to Scott's question?  If you're the wrong owner we need to
know immediately!

Comment 9

[Jean-Francois Ducarroz]

I can reproduce this crash with an optimized build but for some reason, I cannot initialize the spell checker with a 
commercial debug build (Mac or Window). Initialization failed in nsEditorShell::InitSpellChecker() when calling 
mSpellChecker->SetDocument(tsDoc, PR_FALSE) with an error 0xC1F30001. Kin any idea?

Anyway, at this point, I cannot tell if I am the right owner for this bug. Still investigating...

Comment 10

[kinmoz]

I have a fix for this problem.

Comment 11

[kinmoz]

Accepting bug. changing milestone to M19.

Comment 12

[kinmoz]

Attachment: Patch that fixes the crash.

Comment 13

[kinmoz]

Cc [e-mail].

Can I get brade to review and sfraser to super review this fix please? Thanks!

Comment 14

[Kathleen :Brade]

r=brade

Comment 15

[Simon Fraser [no longer active]]

sr=sfraser

Comment 16

[kinmoz]

Removing "need info" from the whiteboard, and sending request to PDT for rtm++ 
approval.

Comment 17

[Phil Peterson]

rtm++

Comment 18

[anthonyd]

kin has a fix for this and a patch.

anthonyd

Comment 19

[kinmoz]

Fix checked into the Netscape_20000922_BRANCH:

    mozilla/editor/ui/dialogs/content/EdSpellCheck.js   revision 1.24.6.1
    mozilla/editor/ui/dialogs/content/EdSpellCheck.xul  revision 1.34.6.1

and the trunk:

    mozilla/editor/ui/dialogs/content/EdSpellCheck.js   revision 1.25
    mozilla/editor/ui/dialogs/content/EdSpellCheck.xul  revision 1.35

Comment 20

[pmock]

Using today commercial branch build, the crash has not been reproducible on 
win32, linux, and mac using the following build:
 win32 commercial seamonkey build 2000-101109-mn6 installed on P500 Win98
 linux commercial seamonkey build 2000-101109-mn6 installed on P200 RedHat 6.2
 macos commercial seamonkey build 2000-101110-mn6 installed on G3/400 OS 9.04

... but will wait for bug 56129 to be fixed first since saving draft is broken.

Comment 21

[fenella]

Linux (2000-10-18-09 MN6)
Win32 (2000-10-18-10 MN6)
Mac (2000-10-18-08 MN6)
Following the same scenario, I try save/don't save/cancel and  Xclose box, no
crash occurs.