528588 - add-on update dialog coming up

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

This dialog has shown up with trying to start the browser.

http://www.flickr.com/photos/madhava_work/4101577750/in/photostream/

We should be catching this and doing it within the browser instead.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Disable all attempts of the nsExtensionManager code from notifying the user that new add-ons are available.

Fennec currently handles this via a manual check in the Add-ons Manager

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 412280 [details] [diff] [review]
patch

>diff --git a/app/mobile.js b/app/mobile.js

>+pref("extensions.update.notifyUser", false);

I'd omit this one since it is potentially confusing.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with nit fixed:
https://hg.mozilla.org/mobile-browser/rev/f48724db5471

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Windows; U; Window3sCE 5.2; en-US; rv:1.9.2b4pre) Gecko/20091116 Namoroka/3.6b4pre Fennec/1.0a4pre

and

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b3pre) Gecko/20091116 Firefox/3.6b4pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091116 Firefox/3.7a1pre Fennec/1.0b5

Comment 5

[Aakash Desai [:aakashd]]

The add-on update dialog popping up at startup will be obvious enough to find without a testcase in litmus.