528611 - on highlighted rows, button corners are white

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

As shown here:
http://www.flickr.com/photos/madhava_work/4101721918/sizes/o/

The areas between the rounded button corner and the edges of the containing rectangle should have the background color.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

We need to either make the border images transparent, or just change the active button backgrounds to match the "highlight" blue. The former is cleaner and less fragile but potentially perf-impacting.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch use transparent corners for the image.

This could _potentially_ regress perfs during pan.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 414006 [details] [diff] [review]
Patch

We will need to keep an eye on the drawing and panning impact.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/34ae3d6ecad6

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b4pre) Gecko/20091125 Firefox/3.6b4pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091125 Firefox/3.7a1pre Fennec/1.0b5