Closed Bug 528634 Opened 10 years ago Closed 10 years ago

use property flags for which properties need StartLoadImage

Categories

(Core :: CSS Parsing and Computation, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Right now nsCSSDataBlock has some if-else cascades for which properties need StartLoadImage calls.  We should make these use property flags instead.

(This is followup to the patch to bug 517224.)
Attachment #412315 - Flags: review?(bzbarsky)
Comment on attachment 412315 [details] [diff] [review]
patch

Looks ok.  If we wanted to reduce code duplication, we could pass the iProp to TryToStartImageLoad and look up the inArray boolean in just one place...  Might make sense from a readability perspective; probably compiles to the same code.
Attachment #412315 - Flags: review?(bzbarsky) → review+
http://hg.mozilla.org/mozilla-central/rev/6af36fcff9bb

I took your advice about passing the property in and only doing the array check in one place.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Priority: -- → P5
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.