Closed Bug 52869 Opened 26 years ago Closed 24 years ago

InstallTrigger callbacks on the wrong thread

Categories

(Core Graveyard :: Installer: XPInstall Engine, defect, P2)

Product:
Core Graveyard
Component:
Installer: XPInstall Engine
Platform:
All
Other
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME
Milestone:
mozilla1.0

People

(Reporter: dveditz, Assigned: dveditz)

Details

(Whiteboard: [xpibug][smartupdate] [ADT2])

XPInstall callbacks are coming in on the XPInstall thread, and web pages which do UI stuff within them cause all sorts of problems. Doing a setTimeout() in the callback and doing the UI actions there seems to help, probably because the event queue is served on the correct UI thread. This is causing problems for Netcenter's SmartUpdate site.
This is a relatively obscure problem and has a workaround (however ugly), I'm afraid it's got to be nsbeta3- for this release. Of course that complicates life because either the SmartUpdate site has to be coded for two versions of N6 or else it'll always have to use the ugly workaround just in case.
Keywords: nsbeta3, rtm
Whiteboard: [nsbeta3-]
Ccing David.
Risky change (involving threading) for first release, there is a workaround we'll have to document.
Whiteboard: [nsbeta3-] → [nsbeta3-][rtm-]
Gee, it sure looks like I tried to get on the correct thread. Bummer if this is still broken. nsbeta1
Keywords: nsbeta3 → nsbeta1
Whiteboard: [nsbeta3-][rtm-] → [rtm-]
Whiteboard: [rtm-] → [xpibug][rtm-]
Moz 0.9 tasks
Target Milestone: --- → mozilla0.9
Priority: P3 → P2
Keywords: nsbeta1, rtm → nsbeta1+
Whiteboard: [xpibug][rtm-] → [xpibug][smartupdate]
Target Milestone: mozilla0.9 → mozilla0.9.1
Target Milestone: mozilla0.9.1 → mozilla0.9.2
reassigning
Assignee: dveditz → syd
Can I get some steps to duplicate this bug with? Might also be nice to check and see if it is still a problem, last touched in January.
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Missed 0.9.3.
Target Milestone: mozilla0.9.3 → mozilla0.9.4
moving to mozilla1.0
Target Milestone: mozilla0.9.4 → mozilla1.0
Keywords: nsbeta1+
Taking these two
Assignee: syd → dveditz
Status: NEW → ASSIGNED
Adding bug 108098 and bug 109139 as dependencies, because fixing this seems like it will fix'em. ADT2 per ADT/XPInstall triage.
Depends on: 108098, 109139
Whiteboard: [xpibug][smartupdate] → [xpibug][smartupdate] [ADT2]
bug 53622 is a better duplicate *** This bug has been marked as a duplicate of 53622 ***
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
oops, wrong bug
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
There's code to switch this over to the correct thread, as far as I can tell that's what's happening, but all that was written before this bug was. Without the testcase showing where setTimeout() was required I can't really demonstrate that a problem still exists.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
No longer depends on: 108098, 109139
Resolution: --- → WORKSFORME
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.