528765 - test_privatebrowsing_downloadLastDir.js random failure

Status: RESOLVED DUPLICATE of bug 535585

(Firefox :: Private Browsing, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1258241716.1258248475.2901.gz
WINNT 5.2 mozilla-central debug test everythingelse on 2009/11/14 15:35:16  
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-everythingelse\build\xpcshell\tests\test_downloads\unit\test_privatebrowsing_downloadLastDir.js | test failed (with xpcshell return code: 1), see following log:

Comment 1

[Phil Ringnalda (:philor)]

I saw the following log, and read up and down and up and down and didn't actually see what the error was, thus my failure to file.

Comment 2

[(no longer active)]

Looking at the error log, I can't understand why this was reported as an error -- all of the tests have passed.  Is this error coming from xpcshell's return code only?  What could change its return code?

Comment 3

[Phil Ringnalda (:philor)]

I've now seen several of these (with the "failure" in some other test, like http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1258337652.1258340852.18582.gz) and have yet to see anyone explain what they mean.

Comment 4

[(not currently active) Ted Mielczarek]

I don't actually know what's happening there. xpcshell returns the result of ProcessArgs, which can return 1 a number of places (but I would expect that your test would not have executed in those cases), or can return gExitCode:
http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/shell/xpcshell.cpp#1217
(gExitCode would also be set to N if you called quit(N))

Comment 5

[(no longer active)]

(In reply to comment #4)
> I don't actually know what's happening there. xpcshell returns the result of
> ProcessArgs, which can return 1 a number of places (but I would expect that
> your test would not have executed in those cases), or can return gExitCode:
> http://mxr.mozilla.org/mozilla-central/source/js/src/xpconnect/shell/xpcshell.cpp#1217
> (gExitCode would also be set to N if you called quit(N))

But obviously this test is not doing any of those things...  Do you know of anyone who can help me here?