Closed
Bug 52879
Opened 26 years ago
Closed 26 years ago
Fails to start on Windows
Categories
(SeaMonkey :: General, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bugzilla, Assigned: security-bugs)
Details
(Keywords: smoketest)
Can't start builds I just pulled on Windows; av and bryner see this also.
It asserts in nr_ReadDesc on
XP_ASSERT(offset < reg->hdr.avail);
where offset is 356741, and then terminates.
NTDLL! 77f76148()
nr_ReadDesc(_regfile * 0x00ed6a80, long 356741, _desc * 0x0012fc54) line 840 +
41 bytes
nr_ReplaceName(_regfile * 0x00ed6a80, long 356741, char * 0x00eca47c, unsigned
long 2048, _desc * 0x0012fc54) line 1372 + 17 bytes
NR_RegEnumSubkeys(void * 0x00ed6790, long 559, unsigned long * 0x00ecac80, char
* 0x00eca47c, unsigned long 2048, unsigned long 0) line 3447 + 25 bytes
nsRegSubtreeEnumerator::advance(nsRegSubtreeEnumerator * const 0x00eca468) line
1634 + 50 bytes
nsRegSubtreeEnumerator::Next(nsRegSubtreeEnumerator * const 0x00eca468) line
1619 + 12 bytes
nsNativeComponentLoader::Init(nsNativeComponentLoader * const 0x00ed5300,
nsIComponentManager * 0x00ed4c10, nsISupports * 0x00ed6e30) line 192 + 34 bytes
nsComponentManagerImpl::PlatformInit() line 474 + 29 bytes
nsComponentManagerImpl::Init() line 326 + 8 bytes
NS_InitXPCOM2(const char * 0x00000000, nsIServiceManager * * 0x00000000, nsIFile
* 0x00000000) line 277 + 8 bytes
NS_InitXPCOM(nsIServiceManager * * 0x00000000, nsIFile * 0x00000000) line 200 +
15 bytes
main(int 1, char * * 0x00ed3370) line 1136 + 10 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77f1b304()
Brian says it works with JAR disabled, i'm testing this theory now...
Comment 2•26 years ago
|
||
When trying to test no-jars on windows, you should set MOZ_OLD_JAR_PACKAGING,
as MOZ_DISABLE_JAR_PACKAGING doesn't work in the new packaging scheme.
At least, that's what read in rules.mak
Axel
Comment 3•26 years ago
|
||
If you delete component.reg does the problem go away? This could be old corruption.
| Reporter | ||
Comment 4•26 years ago
|
||
Deleted component.reg, still hanging. Clobbering now...
I hang too if I continued the assertion.
NTDLL! 77f7629c()
nsDebug::Assertion(const char * 0x0141b194, const char * 0x100c6454, const char
* 0x0141b15c, int 0x00000236) line 256 + 13 bytes
nsDebug::NotReached(const char * 0x0141b194, const char * 0x0141b15c, int
0x00000236) line 414 + 22 bytes
nsResChannel::SetBufferSegmentSize(nsResChannel * const 0x00b5c210, unsigned int
0x00004000) line 566 + 21 bytes
NS_OpenURI(nsIChannel * * 0x0012e504, nsIURI * 0x00b5ba20, nsIIOService *
0x00b6d0a0, nsILoadGroup * 0x00000000, nsIInterfaceRequestor * 0x00000000,
unsigned int 0x00000800, unsigned int 0x00004000, unsigned int 0x00040000) line
122 + 16 bytes
nsDownloader::Init(nsDownloader * const 0x00b5c3b0, nsIURI * 0x00b5ba20,
nsIDownloadObserver * 0x00b5cafc, nsISupports * 0x00000000, nsILoadGroup *
0x00000000, nsIInterfaceRequestor * 0x00000000, unsigned int 0x00000800,
unsigned int 0x00004000, unsigned int 0x00040000) line 57 + 55 bytes
NS_NewDownloader(nsIDownloader * * 0x00b5cb64, nsIURI * 0x00b5ba20,
nsIDownloadObserver * 0x00b5cafc, nsISupports * 0x00000000, nsILoadGroup *
0x00000000, nsIInterfaceRequestor * 0x00000000, unsigned int 0x00000000,
unsigned int 0x00004000, unsigned int 0x00040000) line 336 + 55 bytes
nsJARChannel::EnsureJARFileAvailable() line 343 + 119 bytes
nsJARChannel::OpenInputStream(nsJARChannel * const 0x00b5caf0, nsIInputStream *
* 0x0012ea3c) line 268 + 8 bytes
rdf_BlockingParse(nsIURI * 0x00b596f0, nsIStreamListener * 0x00b580f0) line 606
+ 39 bytes
RDFXMLDataSourceImpl::Refresh(RDFXMLDataSourceImpl * const 0x00b580e4, int
0x00000001) line 946 + 58 bytes
nsChromeRegistry::InstallProvider(nsChromeRegistry * const 0x00b6bb20, const
nsCString & {...}, const nsCString & {...}, int 0x00000000, int 0x00000001, int
0x00000000) line 1752
nsChromeRegistry::InstallPackage(nsChromeRegistry * const 0x00b6bb20, const char
* 0x0012f924, int 0x00000000) line 2088 + 44 bytes
nsChromeRegistry::ProcessNewChromeBuffer(char * 0x00b58196, int 0x000001f3) line
2664 + 38 bytes
nsChromeRegistry::CheckForNewChrome(nsChromeRegistry * const 0x00b6bb20) line
2567 + 16 bytes
CheckForNewChrome() line 716 + 23 bytes
main1(int 0x00000002, char * * 0x00aa3110, nsISupports * 0x00aa30d0) line 868
main(int 0x00000002, char * * 0x00aa3110) line 1139 + 37 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77f1ba06()
Comment 6•26 years ago
|
||
These are two separate problems. libreg uses PR_Assert() and you cannot
continue past it, it calls abort() and you are done.
The download observer stuff is similar to where I was hanging, and suspiciously
runs through files mstoltz checked in today.
Comment 7•26 years ago
|
||
A. I think this should go to Mitch.
B. If turning of jar packaging gets past this, then do it. set
MOZ_DISABLE_JAR_PACKAGING=1 and rebuild: nmake -f makefile.win install (at the
top). A quick and dirty way to turn off jar packaging now is to edit your
installed-chrome.txt file to say things like this:
locale,install,url,resource:/chrome/en-US
(for all of them) instead of this:
locale,install,url,jar:resource:/chrome/en-US.jar!/
Assignee: warren → mstoltz
Comment 8•26 years ago
|
||
Above instructions are not very clear.
1. Are the instructions in B an either/or or do I need to do both?
2. Do you mean client.mak instead of makefile.win?
Anybody has a success with Warren's workaround? My installed-chrome.txt looks
like this:
content,install,url,resource:/chrome/packages/widget-toolkit/
content,install,url,resource:/chrome/packages/core/
locale,install,url,resource:/chrome/locales/en-US/
skin,install,url,resource:/chrome/skins/classic/
skin,install,url,resource:/chrome/skins/blue/
skin,install,url,resource:/chrome/skins/modern/
skin,install,select,classic/1.0
locale,install,select,en-US
content,install,url,resource:/chrome/packages/messenger/
It still crashes after nmake -f client.mak install with
MOZ_DISABLE_JAR_PACKAGING=1. What do I do?
| Reporter | ||
Comment 10•26 years ago
|
||
av: it also did not work for me until i set MOZ_OLD_JAR_PACKAGING=1 (in
addition to MOZ_DISABLE_JAR_PACKAGING=1)
if it *still* doesn't work, clobber and try again (with the aforementioned env
vars set)
Comment 11•26 years ago
|
||
Doing the following did not work for me:
set MOZ_OLD_JAR_PACKAGING=1
set MOZ_DISABLE_JAR_PACKAGING=1
nmake -f client.mak install
I'm trying a clobber and rebuild to see if I have better luck with that.
Comment 12•26 years ago
|
||
Pulling fresh tree and build with those two variables defined didn't help
either.
Comment 13•26 years ago
|
||
And forgot to mention, it hangs after the following output to the console:
Start reading in bookmarks.html
Finished reading in bookmarks.html (100000 microseconds)
WARNING: chrome: failed to get base url for chrome://communicator/skin/tasksOver
lay.css -- using wacky default, file y:\mozilla\rdf\chrome\src\nsChromeRegistry.
cpp, line 515
CSSLoaderImpl::DidLoadStyle: Load of URL 'chrome://communicator/skin/tasksOverla
y.css' failed. Error code: 16389
WARNING: chrome: failed to get base url for chrome://communicator/skin/tasksOver
lay.css -- using wacky default, file y:\mozilla\rdf\chrome\src\nsChromeRegistry.
cpp, line 515
CSSLoaderImpl::DidLoadStyle: Load of URL 'chrome://communicator/skin/tasksOverla
y.css' failed. Error code: 16389
*** Failed to load overlay chrome://communicator/content/PSMTaskMenu.xul
*** Failed to load overlay chrome://communicator/content/securityOverlay.xul
WEBSHELL+ = 3
WARNING: chrome: failed to get base url for chrome://global/skin/scrollbars.css
-- using wacky default, file y:\mozilla\rdf\chrome\src\nsChromeRegistry.cpp, lin
e 515
CSSLoaderImpl::LoadAgentSheet: Load of URL 'chrome://global/skin/scrollbars.css'
failed. Error code: 16389
Enabling Quirk StyleSheet
| Reporter | ||
Comment 14•26 years ago
|
||
Have you followed the instructions at the top of tbox for what to do if your
overlays don't load properly?
Comment 15•26 years ago
|
||
I just tried a clobber build, setting the two enviroronment variables mentioned
above. Now my symptoms are different. Previously I was getting the not-reached
assertion as others mentioned above and was unable to continue executing from
there. Now I am just getting an outright hang with no assertion. I did a break
with the debugger to see where it was hanging. There was nothing interesting on
the thread that was running but on one of the other threads I found the
following:
nsAppShellService::Run(nsAppShellService * const 0x027a1d20) line 379
nsProfile::LoadDefaultProfileDir(nsCString & {...}) line 442 + 32 bytes
nsProfile::StartupWithArgs(nsProfile * const 0x027a2570, nsICmdLineService *
0x0277b2c0) line 363 + 12 bytes
main1(int 1, char * * 0x00ab4f10, nsISupports * 0x00000000) line 909 + 41 bytes
main(int 1, char * * 0x00ab4f10) line 1139 + 37 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77f1ba3c()
The last few lines of my console output are:
mozilla\rdf\chrome\src\nsChromeRegistry.cpp, line 1769
***** Chrome Registration: Selecting skin classic/1.0 as default
WEBSHELL+ = 1
plugins at: C:\Program Files\Netscape\Communicator\Program\Plugins
plugins at: Y:\mozilla\dist\WIN32_D.OBJ\bin\plugins
WARNING: chrome: failed to get base url for chrome://global/skin/scrollbars.css
-- using wacky default, file y:\mozilla\rdf\chrome\src\nsChromeRegistry.cpp, lin
e 515
CSSLoaderImpl::LoadAgentSheet: Load of URL 'chrome://global/skin/scrollbars.css'
failed. Error code: 16389
Note: verifyreflow is disabled
Comment 16•26 years ago
|
||
Following the overlay instructions at the top of tinderbox didn't make any
difference.
Comment 17•26 years ago
|
||
I also tried overlays instructions, doesn't seem to affect anything.
Comment 18•26 years ago
|
||
Morse: MOZ_OLD_JAR_PACKAGING is not what you want. Follow my previous
instructions. Either set MOZ_DISABLE_JAR_PACKAGING and rebuild, or edit the
installed-chrome.txt file.
Comment 19•26 years ago
|
||
Alex, Blake: MOZ_OLD_JAR_PACKAGING is dead code and no longer works. You're
throwing people off.
Comment 21•26 years ago
|
||
Here's how I worked around the jar channel bustage. First update
netwerk/protocol/res/src/nsResChannel.cpp
(I just checked in a change), and rebuild that directory and netwerk/build.
Next, delete dist/win32_d.obj/bin/component.reg.
Finally, use this for your dist/win32_d.obj/bin/chrome/installed-chrome.txt
file:
content,install,url,resource:/chrome/packages/widget-toolkit/
content,install,url,resource:/chrome/packages/core/
locale,install,url,resource:/chrome/locales/en-US/
skin,install,url,resource:/chrome/skins/classic/
skin,install,url,resource:/chrome/skins/blue/
skin,install,url,resource:/chrome/skins/modern/
skin,install,select,classic/1.0
locale,install,select,en-US
content,install,url,resource:/chrome/packages/messenger/
I was able to bring up the browser at this point.
Warren
Comment 22•26 years ago
|
||
Anybody had a success? I did not. The strange thing is, after I updated
nsResChannel.cpp it did not show any diffs. I'll try later.
Comment 23•26 years ago
|
||
I ended up backing Mitch's changes out of the netwerk/protocol/jar/src
directory. I needed to do that to make progress with bug 45937 tonight. Also,
Mitch did not fix my objections to nsJARURI.cpp before checking in.
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Comment 24•26 years ago
|
||
I finally got my build to start successfully. I haven't seen this mentioned
since Friday, but the user-skins.rdf file in my profile's chrome directory was
preventing moz from starting.
| Assignee | ||
Comment 25•26 years ago
|
||
Warren,
at 15:28, you said that checking in to nsResChannel fixed the problem, and at
19:58 you backed me out. So did the ResCDhannel fix work or didn't it? Or was
there some other problem?
Comment 26•26 years ago
|
||
I had to add the unimplemented methods to res channel so that people could even
run without jar packaging turned on. When I backed your stuff out, it was to
make jar packaging work too.
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•