528873 - Attachment Editing form, requestee fields no longer collapse when clearing review flags

Status: RESOLVED DUPLICATE of bug 179626

(Bugzilla :: Attachments & Requests, defect)

Description

[Mark Banner (:standard8)]

In bugzilla 3.2 whilst editing an attachment, i.e. reviewing with "Edit attachment as comment", you could set all the review flags to "blank" at which point the requestee fields would collapse.

Now in bugzilla 3.4 this doesn't happen. This is going to make it even more difficult to review patches especially on narrow screens like when I'm remote on my laptop.

Whilst there's probably a bug that the attachment box should be resizeable, I'm guessing that hasn't been fixed in 3.4 and so it will be quite a while before we get it.

Comment 1

[[e-mail]]

In my userContent.css I use

#editFrame, #viewFrame, #viewDiffFrame {
  font: medium -moz-fixed;
  min-width: 82ch;
}

amongst other styles to get Bugzilla to look reasonable.

Comment 2

[Reed Loden [:reed]]

I'm not aware of any bmo-specific thing that has broken this, so forwarding upstream.

Comment 3

[Guy Pyrzak]

@standard8, is the problem that in 3.2 you used to set ? to blank and then click "edit attachment as comment" and the screen not using an elastic layout would then become too wide to use? 

Basically I am don't want to fix the leak when the whole pipe should be replaced. You're not the first person to say "the screen is too wide when i click "Edit attachment as comment" which seems to be the actual bug you are reporting. 

Do you know the bug number for "make attachment box resizeable? I have that code in my back pocket already and that seems to be the real problem.

I also think a redesign of how the page looks when  you click "edit attachment as comment" might be in order because i totally agree that it is kinda wonky.

I'm going to attach a quick and dirty mock of how i think the edit attachment as comment should look to be more usable, let me know what you think.

Comment 4

[Guy Pyrzak]

Attachment: Edit as Comment

Here is the screenshot. The main differences here is the assumption is that if you're doing this sort of action you are not going to need to edit the type of file, the description or the file name so why have the text fields appear and take up room. The only think you're going to do is set it as obsolete, make your edit or review the patch. So that's what we're showing. This UI more than easily accommodates the 800 by 600 screen that you might have on your laptop and if we make the UI elastic it should be even able to get smaller.

Thoughts?

Comment 5

[Guy Pyrzak]

Attachment: Super Rough Mock Concept of new Attachment layout

Here is an idea for how it might look if it was just a normal layout. The things to point out here that are not clear from the mock is that the attachment viewing box AND the comment box would grow horizontally to fit the width of the page.

Sorry for not being clear about that in the mock.

I'm really not happy with where the patch and obsolete buttons are but I'm not sure what a better place to put them is, maybe next to the description. Thoughts? Critics? etc

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #3)
> @standard8, is the problem that in 3.2 you used to set ? to blank and then
> click "edit attachment as comment" and the screen not using an elastic layout
> would then become too wide to use? 

No. In 3.2 you could change ? to blank, and the field where you enter the reviewer's email would collapse to zero width. The attachment box would then expand in width to take up the space just created and give you extra width.

> Basically I am don't want to fix the leak when the whole pipe should be
> replaced. You're not the first person to say "the screen is too wide when i
> click "Edit attachment as comment" which seems to be the actual bug you are
> reporting. 

Except that's not what I'm saying, and I'm not sure what you mean by leaking.

> Do you know the bug number for "make attachment box resizeable? I have that
> code in my back pocket already and that seems to be the real problem.

Nope, but that might be useful.

I'll try and have a look at the screenshots later.

Comment 7

[Guy Pyrzak]

By leak i mean showing and hiding the requestee textbox. By replacing the pipe i mean I think the edit attachments layout needs to be redone. 

Basically I think the real problem is the layout of the whole page not the requestee box showing up. And by fixing this bug so that it would be less broken is not as good as fixing the layout so that you don't care about the requestee box being there or not. 

Basically I think the layout is broken and making the requestee text box disappear is a band-aid to fix the bigger problem.

see bug 101770, their complaint is about the comments field being too small that's also because the attachment layout is bad. I think both of your bugs could be fixed by the new layout being suggested.

Comment 8

[Guy Pyrzak]

after talking with LpSolit i see that the bug is about actually removing the text box itself not about how the text box takes up valuable screen real estate. 

However with the new UI from bug 101770 this bug becomes more of an aesthetic annoyance than a usability bug.

Comment 9

[Frédéric Buclin]

Already fixed by bug 179626 in Bugzilla 4.0.