528963 - Crash [@ txXPathNode::RootOf]

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Paul Nickerson]

Attachment: testcase

Nonexploitable crash - may be related to bug 528590.

Comment 1

[Paul Nickerson]

Attachment: stack

Comment 2

[Peter Van der Beken [:peterv]]

Attachment: v1

matches(...) returns a boolean, so we don't report errors when evaluating most patterns. We do return early in txXSLKey::testNode without popping the eval context that we pushed, but we ignore the error it returns and keep going with an eval context stack that doesn't reflect reality. I decided to not change matches' signature in this bug, since that's a very invasive change, but instead just pop the eval context before returning. I'll file a bug about matches if we don't have one already.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Did you attach the wrong file?

Comment 4

[Peter Van der Beken [:peterv]]

Attachment: v1

Sigh.

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 413559 [details] [diff] [review]
v1

Simple crash fix.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 413559 [details] [diff] [review]
v1

a192=beltzner

Comment 7

[Peter Van der Beken [:peterv]]

http://hg.mozilla.org/mozilla-central/rev/abd62f4f05fb
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/dbffc9cdb001