Closed
Bug 529077
Opened 15 years ago
Closed 15 years ago
DirectoryProvider.js cleanup
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
fennec1.0
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
Attachments
(1 file)
|
1.53 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
We don't need to support nsIDirectoryProviderService2 yet. Also, based on the way the return values are checked, we should just return NULL from JS to signify failure.
|
Assignee | |
Updated•15 years ago
|
Attachment #412655 -
Attachment is patch: true
Attachment #412655 -
Attachment mime type: application/octet-stream → text/plain
Attachment #412655 -
Flags: review?(gavin.sharp)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 412655 [details] [diff] [review]
patch
Add a comment about the fact that we're relying on callers checking more than just rv? This is a bit risky, but probably OK to rely on I guess.
Attachment #412655 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
adding comment
also see http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsDirectoryService.cpp#614
|
|
Assignee | |
Comment 3•15 years ago
|
||
pushed with comment added:
https://hg.mozilla.org/mobile-browser/rev/2b8ad2d08b67
Assignee: nobody → mark.finkle
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
You need to log in
before you can comment on or make changes to this bug.
Description
•