Created attachment 412655 [details] [diff] [review] patch We don't need to support nsIDirectoryProviderService2 yet. Also, based on the way the return values are checked, we should just return NULL from JS to signify failure.
Comment on attachment 412655 [details] [diff] [review] patch Add a comment about the fact that we're relying on callers checking more than just rv? This is a bit risky, but probably OK to rely on I guess.
Attachment #412655 - Flags: review?(gavin.sharp) → review+
adding comment also see http://mxr.mozilla.org/mozilla-central/source/xpcom/io/nsDirectoryService.cpp#614
pushed with comment added: https://hg.mozilla.org/mobile-browser/rev/2b8ad2d08b67
Assignee: nobody → mark.finkle
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
You need to log in before you can comment on or make changes to this bug.