Closed Bug 529077 Opened 13 years ago Closed 13 years ago

DirectoryProvider.js cleanup

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
fennec1.0

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
We don't need to support nsIDirectoryProviderService2 yet. Also, based on the way the return values are checked, we should just return NULL from JS to signify failure.
Attachment #412655 - Attachment is patch: true
Attachment #412655 - Attachment mime type: application/octet-stream → text/plain
Attachment #412655 - Flags: review?(gavin.sharp)
Comment on attachment 412655 [details] [diff] [review]
patch

Add a comment about the fact that we're relying on callers checking more than just rv? This is a bit risky, but probably OK to rely on I guess.
Attachment #412655 - Flags: review?(gavin.sharp) → review+
pushed with comment added:
https://hg.mozilla.org/mobile-browser/rev/2b8ad2d08b67
Assignee: nobody → mark.finkle
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
You need to log in before you can comment on or make changes to this bug.