529125 - Regression: Controls are slightly pannable

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Benjamin Stover (:stechz)]

When panning a page with a sidebar open, the sidebar controls will move a few pixels.

Comment 1

[Benjamin Stover (:stechz)]

Only happening for me on the N900.

Comment 2

[Aakash Desai [:aakashd]]

I can confirm this on build:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b3pre) Gecko/20091116 Firefox/3.6b4pre Fennec/1.0b6pre

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Vivien - Bug 529236 has a patch to fix this bug and another. Even we land the patch in bug 529236, should we still take this patch because it's more robust than the current code?

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #4)
> Vivien - Bug 529236 has a patch to fix this bug and another. Even we land the
> patch in bug 529236, should we still take this patch because it's more robust
> than the current code?

This patch also fix both bugs :)

I think it is more robust because the patch didn't rely on container.top which can be misleading.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 412723 [details] [diff] [review]
Patch

Since this patch fixes both bugs and doesn't relay on delaying code, I think this would be the better fix.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/906c4c1ccb97

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b3pre) Gecko/20091118 Firefox/3.6b4pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091118 Firefox/3.7a1pre Fennec/1.0b5