Closed Bug 529173 Opened 12 years ago Closed 2 years ago

Replace search.json with startup cache

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: taras.mozilla, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [ts])

No description provided.
Whiteboard: [ts]
No longer blocks: 520309
Depends on: 520309
Component: General → Search
OS: Linux → All
Product: Core → Firefox
QA Contact: general → search
Hardware: x86 → All
Summary: replace searchengines.json with startup cache → replace search.json with startup cache
Blocks: 447581
Taras: I assume that this bug is basically "don't dump 160KB of JSON to disk; let's store something precompiled", right?

Is there a reason for startup cache instead of BSON, or even writing favicons separately?

We want something like this to avoid chewing up so much space in Fennec profiles.
Blocks: 1042372
Flags: needinfo?(taras.mozilla)
Richard, this was more to do with data locality. less files to read => faster. As far as formats, bson sucks. json + gzip or json + lzma win over every binary json format + compression I tried.

Startup cache is nice because it's a zip, so you get compression for free.
Flags: needinfo?(taras.mozilla)
Great. So long as we get a space saving, I'm happy :)

What's the next step for getting this moving?
(In reply to Richard Newman [:rnewman] from comment #3)
> Great. So long as we get a space saving, I'm happy :)
> 
> What's the next step for getting this moving?

implement it?
Heh.

Let's see if these fancy new backlog flags make a difference…
Flags: firefox-backlog?
Summary: replace search.json with startup cache → Replace search.json with startup cache
I don't know what the breakdown of profile space on Fennec looks like or how many thousands of papercuts you're suffering from, but 160KB doesn't seem very big to me, so without context the size argument isn't particularly convincing.

This seems like it would be a significant chunk of work, and there's little evidence that it will help startup significantly (particularly now that search initialization is all async), so I don't think there's enough win here to justify the cost.
Flags: firefox-backlog? → firefox-backlog-
I'm likely to replace search.json in bug 1203167. If the size of the base64 encoded icon files is a problem, the bug to fix it is bug 986676.

search.json is now a compressed lz4 file. Not sure if the icons are still an issue or not - but if so, that's bug 986676 as mentioned in the previous comment.

As this doesn't seem to be a current issue with startup, I'm going to close this out. We can always re-open or file a new issue if we find something significant.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.