529235 - Unable to open additional dictionary download page from spell-checker dialog

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Nathan Tuggy (:tuggyne)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.5) Gecko/20091112 Thunderbird/3.0

In 3.0rc1 build 1, I am unable to open the page to download additional dictionaries from the spell-checker dialog: When I click the Language drop-down and select Download more dictionaries..., nothing happens.

Reproducible: Always

Steps to Reproduce:
See the Litmus testcase for this at https://litmus.mozilla.org/show_test.cgi?id=5507

1. Compose a message
2. Open the Spell Checker dialog, e.g. from the toolbar
3. Attempt to select Download more dictionaries... from the Language drop-down
Actual Results:  
Nothing happens except that the drop-down closes.

Expected Results:  
A webpage to open in my default browser, or in Thunderbird, with options to download additional dictionaries.

IMAP-account composition tested only, on profile migrated from b4. Both plain-text and HTML exhibit identical behavior.

Comment 1

[Mark Banner (:standard8)]

Confirming regression, this is broken UI so going to block TB 3 especially as we're doing a build 2 of RC 1 anyway.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

The code in EdSpellCheck.js bases its decision on how to load the url from the protocol service. Since Thunderbird switched exposing the http(s) protocols on, then this doesn't do what we want as we don't have a browser as such.

Therefore swap this code to use contentAreaUtils.js' openURI - this uses the uriloader to open the url and this means we hook into some of TB's other code which is set up to redirect those type of loads to the external browser.

For SM the only differences are that there's a slightly delay between clicking the menu option and something happening (due to the use of uriloader, however this is exactly the same as the add-on manager and other toolkit links), and I believe it will re-use windows/tabs according to the external load handler preferences.

Comment 3

[[e-mail]]

Comment on attachment 412823 [details] [diff] [review]
The fix

So in fact we'll get better UI too, as we won't open new windows all the time like we used to.

Comment 4

[David :Bienvenu]

Comment on attachment 412823 [details] [diff] [review]
The fix

It would be cool to do this in a TB tab at some point :-)

Comment 5

[Mark Banner (:standard8)]

Checked in:
comm-central: http://hg.mozilla.org/comm-central/rev/4e41e3469c17
comm-1.9.1 (default): http://hg.mozilla.org/releases/comm-1.9.1/rev/44b1055266e9
comm-1.9.1 (relbranch): http://hg.mozilla.org/releases/comm-1.9.1/rev/eb5ce305554a