529297 - Addons Manager: Late UI when installing an add-on via Search

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b3pre) Gecko/20091117 Firefox/3.6b4pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091117 Firefox/3.7a1pre Fennec/1.0b5

Steps to Reproduce:
1. Go to the Addons Manager
2. Click on a recommended addon

Actual Results:
It takes 1-2 seconds before the progress bar comes up on the row entry for the recommended add-on. Once it does, it only briefly pops up and goes away.

Expected Results:
The progress bar should come up instantly (even empty) right after the "Add to Firefox" button is clicked. This way the user isn't left wondering what's going on with Firefox. It'll seem like a pseudo-perf win as the add-on installation progress will be considered a slow download rather than a slow process on Fennec.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

I don't see this on winmo. Aakash, do you still see it on maemo?

Comment 2

[Aakash Desai [:aakashd]]

Yep, I definitely see it on the n900 when installing Weave, URL Fixer and Lazy Click on today's nightly build:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2pre) Gecko/20100119 Firefox/3.6pre Fennec/1.1a1pre

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Thinking more on it we probably want to keep setting the opType from the downloading callback, just in case the download was started from elsewhere than installFromRepo.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #5)
> Created an attachment (id=435565) [details]
> Patch v0.2
> 
> Thinking more on it we probably want to keep setting the opType from the
> downloading callback, just in case the download was started from elsewhere than
> installFromRepo.

Exactly!

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/804e2811f373

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.3pre) Gecko/20100330 Namoroka/3.6.3pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.3a4pre) Gecko/20100330 Namoroka/3.7a4pre Fennec/1.1a2pre