nsMIMEInfoUnix.cpp fail to compile with HILDON enabled and MOZ_ENABLE_GNOMEVFS disabled

RESOLVED INACTIVE

Status

()

Firefox
File Handling
RESOLVED INACTIVE
9 years ago
3 days ago

People

(Reporter: romaxa, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

9 years ago
Created attachment 412919 [details] [diff] [review]
Fix

rm -f libxul.so
../../staticlib/components/libdocshell.a(nsOSHelperAppService.o): In function `nsOSHelperAppService::OSProtocolHandlerExists(char const*, int*)':
microb-engine-30000101-1.9.3-38233.9e2ab948c080/uriloader/exthandler/unix/nsOSHelperAppService.cpp:1215: undefined reference to `nsMIMEInfoUnix::HandlerExists(char const*)'
i486-pc-linux-gnu/bin/ld: libxul.so: hidden symbol `nsMIMEInfoUnix::HandlerExists(char const*)' isn't defined
i486-pc-linux-gnu/bin/ld: final link failed: Nonrepresentable section on out
Attachment #412919 - Flags: review?(sdwilsh)
(Reporter)

Comment 1

9 years ago
Created attachment 412992 [details] [diff] [review]
Better version of hildon mime handling
Attachment #412919 - Attachment is obsolete: true
Attachment #412992 - Flags: review?(sdwilsh)
Attachment #412919 - Flags: review?(sdwilsh)
(Reporter)

Comment 2

9 years ago
Comment on attachment 412992 [details] [diff] [review]
Better version of hildon mime handling

defined (MOZ_ENABLE_GNOMEVFS)

I think it is bad idea of wrapping into MOZ_ENABLE_GNOMEVFS just to avoid compilation on Qt
Attachment #412992 - Flags: review?(sdwilsh)

Comment 3

9 years ago
It is not clear what HILDON + Qt imples.  When more information is available, it will probably be obvious.
(Reporter)

Comment 4

9 years ago
This patch is setting different defines in different places...
https://bugzilla.mozilla.org/attachment.cgi?id=412143&action=edit

And finally when MOZ_ENABLE_GNOMEVFS = 0 and MOZ_PLATFORM_HILDON = 1
we are getting this compilation error
(Reporter)

Comment 5

9 years ago
Created attachment 413043 [details] [diff] [review]
replacement for attachment.cgi?id=412992

Qt and Gtk it is one thing
Hildon is different thing.

cairo-qt does not mean that we are not able to use gtk or glib or other libraries... it is only gfx backend

we can have cairo-qt configuration with gnomevfs, hildon, and gtk and that should work.

I was able to compile cairo-qt configuration only with attached patch.
problem was in dgettext compilation.

dougt can you provide build error and mozconfig which you had in 528425?
(Reporter)

Comment 6

9 years ago
Created attachment 413055 [details] [diff] [review]
Partially revert patch from bug 528425

I have checked this patch, and I don't have any problems with building QT with this patch.
Attachment #412992 - Attachment is obsolete: true
Attachment #413055 - Flags: review?(mozbugz)

Comment 7

8 years ago
Comment on attachment 413055 [details] [diff] [review]
Partially revert patch from bug 528425

MOZ_PLATFORM_HILDON no longer exists.
Attachment #413055 - Flags: review?(dougt) → review-

Updated

2 years ago
Component: File Handling → File Handling
Product: Core → Firefox
Version: Trunk → unspecified

Comment 8

3 days ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Last Resolved: 3 days ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.