529433 - Show name and full e-mail in a tooltip for flag setters and requestees

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Nathan Tuggy (:tuggyne)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 (.NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.21022; .NET CLR 3.5.30729)
Build Identifier: 

The useful tooltips that show the full email of the user who set or requested a given flag are no longer present after the upgrade to 3.4.3. See the 'blocking-thunderbird3+' flag in the linked page for an example: all that's shown is 'bugzilla', and the rest of the email (which in full is '[e-mail]') is unavailable. view-source shows no title attribute, nor indeed any reference to the full email.

The workaround is to view change history and determine the user who last set that flag.

Reproducible: Always

Steps to Reproduce:
0. Log in
1. View a bug with one or more flags set
2. Hover over the alias of the user who set or requested that flag
Actual Results:  
No tooltip appears.

Expected Results:  
A tooltip should appear with the full email address of the user who set or requested the flag, for disambiguation.

Just in case, my User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 (.NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.21022; .NET CLR 3.5.30729)

Comment 1

[Reed Loden [:reed]]

This is indeed a regression from bmo 3.2.x, but I don't think it's a Bugzilla regression. However, I'd like to fix it upstream, so I'm going to convert this to a feature request and attach a patch.

Comment 2

[Reed Loden [:reed]]

Attachment: patch - v1

For logged-in users, display the .identity of the flag setter. For logged-out users, display the .name (if it exists) for the flag setter and requestee.

Comment 3

[Frédéric Buclin]

Comment on attachment 416186 [details] [diff] [review]
patch - v1

>@@ -205,9 +213,9 @@
>-[% END %]
>\ No newline at end of file
>+[% END %]

Please remove this block, which doesn't apply anyway. Note that this doesn't affect the attachment table displayed in show_bug.cgi as it doesn't call flag/list.html.tmpl. You will have to update your patch to fix that too. I think you should do it as part of this bug. r=LpSolit for the current code, but awaiting an updated patch for the attachment table.

Comment 4

[Reed Loden [:reed]]

Attachment: patch - v2

Comment 5

[Reed Loden [:reed]]

Comment on attachment 428127 [details] [diff] [review]
patch - v2

Hmm, I noticed a difference between a check in both of the files, so I thought I'd ask about it...

attachment/list.html.tmpl has:
>                 [%+ flag.type.name FILTER html FILTER no_break %][% flag.status %]
>                 [%+ IF flag.status == "?" && flag.requestee %]

while flag/list.html.tmpl has:
>       [%+ type.name FILTER html FILTER no_break %][% flag.status %]
>       [% IF flag.requestee %]

Why is there not a check for |flag.status == "?"| here?

If I had some more time, I could probably read the code more closely and figure it out, but I'm in a hurry tonight, and you'll probably be able to answer quicker.

Comment 6

[Frédéric Buclin]

(In reply to comment #5)
> Why is there not a check for |flag.status == "?"| here?

Because this is useless. If there is a requestee, then the status is "?" for sure. I added these lines in flag/list.html.tmpl in Bugzilla 3.4, while the code from attachment/list.html.tmpl with the useless check is from Bugzilla 2.18.

Comment 7

[Frédéric Buclin]

Comment on attachment 428127 [details] [diff] [review]
patch - v2

r=LpSolit

Comment 8

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified template/en/default/attachment/list.html.tmpl
modified template/en/default/flag/list.html.tmpl                               
Committed revision 7080.

Comment 9

[Max Kanat-Alexander]

Added to the release notes in bug 604256.